Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "new Function" syntax #120

Merged
merged 13 commits into from Jun 16, 2020
Merged

The "new Function" syntax #120

merged 13 commits into from Jun 16, 2020

Conversation

11joselu
Copy link
Contributor

@11joselu 11joselu commented Nov 2, 2019

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team November 2, 2019 17:56
@iliakan iliakan mentioned this pull request Nov 2, 2019
Open
@CLAassistant
Copy link

CLAassistant commented Nov 2, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

iLTW1n
iLTW1n reviewed Nov 15, 2019
View reviewed changes
Copy link

@iLTW1n iLTW1n left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola ✋ @11joselu , gracias por la traducción, hay unos cambios que se necesitaría hacer antes poder unirlo a la traducción.

1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
@11joselu
Copy link
Contributor Author

@JOsktgui Gracias por el feedback :)

Cambios hechos 👍

spideep
spideep suggested changes Dec 10, 2019
View reviewed changes
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCaste
EzequielCaste approved these changes Jun 16, 2020
View reviewed changes
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
1-js/06-advanced-functions/07-new-function/article.md Outdated Show resolved Hide resolved
@EzequielCaste EzequielCaste merged commit 943b805 into javascript-tutorial:master Jun 16, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@11joselu
Copy link
Contributor Author

Gracias @ezzep66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLTW1n iLTW1n iLTW1n left review comments

@spideep spideep spideep requested changes

@EzequielCaste EzequielCaste EzequielCaste approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@11joselu @CLAassistant @javascript-translate-bot @spideep @iLTW1n @EzequielCaste @vplentinax