Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterables #179

Merged
merged 33 commits into from Jun 24, 2020
Merged

Iterables #179

merged 33 commits into from Jun 24, 2020

Conversation

vplentinax
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team May 11, 2020 00:16
@javascript-translate-bot
Copy link

Error: the article already has PR number in the Progress Issue #17, it's 156 ⁉️

@vplentinax
Copy link
Contributor Author

#179 replace #156

@iliakan iliakan mentioned this pull request May 13, 2020
Open
@EzequielCaste EzequielCaste self-requested a review June 22, 2020 14:53
EzequielCaste
EzequielCaste requested changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

por favor ver el tema de los espacios cuando usamos google translate

1-js/05-data-types/06-iterable/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/06-iterable/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/06-iterable/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/06-iterable/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/06-iterable/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/06-iterable/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/06-iterable/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/06-iterable/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/06-iterable/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/06-iterable/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinax and others added 18 commits June 22, 2020 16:15
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
2a82824 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
d1f3421 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
2c53a7c 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
e8d01b6 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
e293868 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
e486340 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
a338457 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
f9c49f6 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
aeb5652 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
37f2a5c 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
b69ef65 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
d2abc4d 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
95769e8 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
d6c10f7 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
4050994 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
63134c7 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
42dde7c 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
6231593 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
vplentinax and others added 13 commits June 22, 2020 16:24
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
a61b486 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
fe3a79c 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
2c8d959 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
7905032 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
a195f98 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
2cf55ac 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
f41c3d8 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
66c34e0 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
9423df1 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
a89b9c3 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
65a4631 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/06-iterable/article.md
2639caa 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax
Update article.md
36b0d08
@vplentinax
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team June 22, 2020 20:34
joaquinelio
joaquinelio approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casi perfecto.
Lástima lo de, a un arreglo vector, llamarlo "matriz" que es una red bidimensional con filas y columnas.
Cuando voto por no traducir nombres, es para:
-cuidar el español
-facilitar aprendizaje evitando falsos sinónimos
y bué...

@joaquinelio
Copy link
Member

@vplentinax ¿por qué sigue figurando chng req? Me pareció que estaba todo resuelto. Te lo dejo. Por mí, MERGE.

@EzequielCaste EzequielCaste merged commit ea67503 into javascript-tutorial:master Jun 24, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@EzequielCaste EzequielCaste EzequielCaste approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vplentinax @javascript-translate-bot @joaquinelio @EzequielCaste