Promise #188
Closed
Promise #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corregido detalles corregido typo
joaquinelio
requested changes
Jun 29, 2020
There was a problem hiding this comment.
Repo borrado. no puedo hacer suggest (dejé 3 comments)
@cortizg
Cambios menores, podés ignorarlos y pedir merge...
aunque no creo, son más estrictos que yo
Falta 1/11/2/2 solution, un solo renglón
typo
acento
elegir 1 palabra por consistencia /manejador/controlador/
EDIT: por qué hojarasca sale la letra dl coment tan grande si no puse ninguna decoracion
|
Please make the requested changes. After it, add a comment "/done". |
Tendré que cerrar el PR y subirlo de nuevo el branch |
|
Cerrado por falta de branch |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.