Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promises chaining #189

Merged
merged 9 commits into from Jun 10, 2020
Merged

Promises chaining #189

merged 9 commits into from Jun 10, 2020

Conversation

cortizg
Copy link
Contributor

@cortizg cortizg commented May 14, 2020

No description provided.

@cortizg
1-11-03-pc Traducido 11
ad176f6 
1-11-03-pc Corregido 8

1-11-03-pc Corregido 8

coregido typos
@javascript-translate-bot javascript-translate-bot requested a review from a team May 14, 2020 17:00
@iliakan iliakan mentioned this pull request May 14, 2020
Open
cortizg
cortizg commented Jun 9, 2020
View reviewed changes
Copy link
Contributor Author

@cortizg cortizg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cambio sugerido

1-js/11-async/03-promise-chaining/01-then-vs-catch/solution.md Outdated Show resolved Hide resolved
cortizg
cortizg commented Jun 9, 2020
View reviewed changes
Copy link
Contributor Author

@cortizg cortizg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es un valor cadena de un symbol, se puede traducir pero prefiero dejarlo a como estaba

1-js/11-async/03-promise-chaining/user.json Outdated Show resolved Hide resolved
cortizg
cortizg commented Jun 9, 2020
View reviewed changes
Copy link
Contributor Author

@cortizg cortizg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detalles y typos

1-js/11-async/03-promise-chaining/article.md Outdated Show resolved Hide resolved
1-js/11-async/03-promise-chaining/article.md Outdated Show resolved Hide resolved
1-js/11-async/03-promise-chaining/article.md Outdated Show resolved Hide resolved
1-js/11-async/03-promise-chaining/article.md Outdated Show resolved Hide resolved
1-js/11-async/03-promise-chaining/article.md Outdated Show resolved Hide resolved
joaquinelio
joaquinelio approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy bueno.
algunas opiniones, no insisto
Algunos conflictos fácil de resolver, apruebo en advance aunque no deba, es para que o molesten más.

1-js/11-async/03-promise-chaining/article.md Show resolved Hide resolved
1-js/11-async/03-promise-chaining/article.md

In frontend programming promises are often used for network requests. So let's see an extended example of that.
En la interfaz de programación, las promesas a menudo se usan para solicitudes de red. Así que veamos un ejemplo extendido de eso.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...¿especialización?"
"Soy frontend... eh... programador de interfaces"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podría poner en el "ambiento de desarrollo"..... Entorno de programación.... Me gusta más.... El problema es que confíaba demasiado en la traducciones google, confíaba😱

Copy link
Contributor Author

@cortizg cortizg Jun 10, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Además JS está en el frontend y en el backend con node y creo que no se usan promesas en node; está bien el contexto porque lo resaltan....node en su núcleo no procesa promesas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tambien podria dejarse como "programacion en el frontend", no se, comentarios?

@vplentinax vplentinax merged commit bc831f3 into javascript-tutorial:master Jun 10, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cortizg @javascript-translate-bot @joaquinelio @vplentinax