Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions #230

Merged
merged 31 commits into from Jul 3, 2020
Merged

Functions #230

merged 31 commits into from Jul 3, 2020

Conversation

vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Jun 5, 2020

Este PR es la corrección al articulo traducido por el colaborador Giorgiosaud Functions #96 . Dicho PR será cerrado y reenumerado en el Issue 17.

@javascript-translate-bot javascript-translate-bot requested a review from a team June 5, 2020 17:34
@vplentinax vplentinax changed the title Giorgiosaud-PR95-correccion Conditional operators: if, '?' Jun 5, 2020
@vplentinax vplentinax changed the title Conditional operators: if, '?' Functions Jun 5, 2020
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

casi listo, algunas correcciones

1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCaste and others added 16 commits June 15, 2020 11:05
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax
Copy link
Contributor Author

/done

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

varios cambiecitos
Pero muy buen schooling, so dont wait for me
cambia lo que quieras y MERGE

Partimos de un falso "mucho hecho", resignamos a que eran menos de 20.
Ahora 60... ¡UN TERCIO DEL SITIO! Y los PR, dentro del mes.
Qué sino para festejo.

1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
vplentinax and others added 14 commits July 2, 2020 17:51
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 2, 2020 21:55
@vplentinax vplentinax merged commit ca8f297 into javascript-tutorial:master Jul 3, 2020
@javascript-translate-bot

Error: the article has another translator @Giorgiosaud, not @vplentinax in the Progress Issue #17. Please update the progress issue or ask maintainers to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants