Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns and flags #237

Merged
merged 26 commits into from Jun 11, 2020
Merged

Patterns and flags #237

merged 26 commits into from Jun 11, 2020

Conversation

cortizg
Copy link
Contributor

@cortizg cortizg commented Jun 9, 2020

se agrega traducción del index del capítulo

@javascript-translate-bot javascript-translate-bot requested a review from a team June 9, 2020 03:54
@iliakan iliakan mentioned this pull request Jun 9, 2020
Open
@cortizg
9-01-ri Traducido 18
bf9ca5f 
se agrega traducción del index del capítulo

typo
EzequielCaste
EzequielCaste requested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @cortizg me gusta tu traducción, aunque prefiero usar bandera y no flag.
Hice varias sugerencias, por favor revisar y corregir.

9-regular-expressions/01-regexp-introduction/article.md Outdated Show resolved Hide resolved
9-regular-expressions/01-regexp-introduction/article.md Outdated Show resolved Hide resolved
9-regular-expressions/01-regexp-introduction/article.md Outdated Show resolved Hide resolved
9-regular-expressions/01-regexp-introduction/article.md Outdated Show resolved Hide resolved
9-regular-expressions/01-regexp-introduction/article.md Outdated Show resolved Hide resolved
9-regular-expressions/01-regexp-introduction/article.md Outdated Show resolved Hide resolved
9-regular-expressions/01-regexp-introduction/article.md Outdated Show resolved Hide resolved
9-regular-expressions/01-regexp-introduction/article.md Outdated Show resolved Hide resolved
9-regular-expressions/01-regexp-introduction/article.md Outdated Show resolved Hide resolved
9-regular-expressions/01-regexp-introduction/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@cortizg cortizg closed this Jun 10, 2020
@cortizg cortizg reopened this Jun 10, 2020
cortizg and others added 20 commits June 10, 2020 13:59
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
cbb314c 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
f8f5b42 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
70ef326 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
d3bc30b 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
fd70dcd 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
056e544 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
5dea5ad 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
e33ec5b 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
eba3900 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
550039e 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
834ac1a 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
31afb25 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
44e59d9 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
9c34e07 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
43196a1 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
b285a9e 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
d8e9a54 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
b992920 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
98c112e 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
e33144e 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
cortizg and others added 4 commits June 10, 2020 14:06
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
ee79bcd 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
dfab9af 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg @EzequielCaste
Update 9-regular-expressions/01-regexp-introduction/article.md
90232f0 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@cortizg
Merge branch 'master' into es.javascript.info.9-01-ri
769ec75
@cortizg
Copy link
Contributor Author

cortizg commented Jun 10, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team June 10, 2020 20:18
cortizg
cortizg commented Jun 10, 2020
View reviewed changes
Copy link
Contributor Author

@cortizg cortizg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visto

EzequielCaste
EzequielCaste approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@vplentinax vplentinax merged commit 4b9ccb5 into javascript-tutorial:master Jun 11, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzequielCaste EzequielCaste EzequielCaste approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cortizg @javascript-translate-bot @EzequielCaste @vplentinax