Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map and Set #263

Merged
merged 24 commits into from
Jul 5, 2020
Merged

Map and Set #263

merged 24 commits into from
Jul 5, 2020

Conversation

vplentinax
Copy link
Contributor

Arreglado los errores de formato.

@javascript-translate-bot javascript-translate-bot requested a review from a team June 18, 2020 21:41
@iliakan iliakan mentioned this pull request Jun 18, 2020
Open
@EzequielCaste EzequielCaste self-requested a review July 4, 2020 14:03
EzequielCaste
EzequielCaste requested changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay error al comienzo de 1-js/05-data-types/07-map-set/02-filter-anagrams/solution.md
No se ha respetado los números de las líneas. Debe comenzar en línea N° 1 y no en la N°2.

Por favor corregir así puedo seguir con la revisión.

1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EzequielCaste
update solution
981da7f 
arreglé el problema de los espacios.
Por favor tienen que coincidir los números de las líneas con el documento Original.
@EzequielCaste
update task
e4ceae7 
problemas con la numeración de líneas
@EzequielCaste
update solution
78e1bfa 
número de líneas
@EzequielCaste
corrección de líneas
e61c2a6 
respetar el número de línea
@EzequielCaste
corrección número líneas
1c79cbe
@EzequielCaste
fixed line numbers
883cd95
EzequielCaste
EzequielCaste requested changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muchos problemas con espacios donde no deberían estar.
Se debe respetar el número de línea del documento original.

1-js/05-data-types/07-map-set/03-iterable-keys/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

vplentinax and others added 12 commits July 4, 2020 19:15
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
e6f57ea 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
af49a81 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
459c874 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
f6f6016 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
438b4d7 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
e101acc 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
f754d71 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/03-iterable-keys/task.md
740687f 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
444e0a5 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
669b0ff 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
c3f6fc4 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
b2df4f7 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
vplentinax and others added 5 commits July 4, 2020 19:18
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
2c56508 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
74fee8b 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
3178435 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
3b5c116 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax
Update task.md
7dcaca0
@vplentinax
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 4, 2020 23:23
@vplentinax vplentinax merged commit 6249f2a into javascript-tutorial:master Jul 5, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
Copy link
Member

joaquinelio commented Jul 5, 2020 •
edited
Loading

@vplentinax @ezzep66
¿Merged? Lo tenía recién en una pestaña para revisión...
Estoy de ACUERDO con los merge aprobados por la trusted people, (después de la carga, revisar el repo entero)
¿pero qué pasó con eso del doble review que pide don Bot?
No me quejo, es saber cuál es el criterio.

@vplentinax
Copy link
Contributor Author

En mis PR el segundo review lo doy yo jejeje.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzequielCaste EzequielCaste EzequielCaste approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vplentinax @javascript-translate-bot @joaquinelio @EzequielCaste