Skip to content

Class inheritance #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 7, 2020
Merged

Class inheritance #274

merged 6 commits into from
Jul 7, 2020

Conversation

cortizg
Copy link
Contributor

@cortizg cortizg commented Jun 22, 2020

Replacing PR #177

@javascript-translate-bot javascript-translate-bot requested a review from a team June 22, 2020 20:25
@javascript-translate-bot
Copy link

Error: the article already has PR number in the Progress Issue #17, it's 171 ⁉️

@iliakan iliakan mentioned this pull request Jul 5, 2020
Open
joaquinelio
joaquinelio requested changes Jul 5, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Override: "montarse encima", a veces decimos "pisar", no es "anular" en programación.
puse sobrescribir en los suggest, tampoco me convence BUSCAR MEJOR PALABRA

Sí podrías ANULAR un método, "sobrescribiendo" uno vacío, pero es más amplio que eso.
Podes reemplazarlo, para que haga algo distinto,
También podes extenderlo, eso es lo que haces con el contructor cuando llamás super(),
edit:
No quise usar "extender", que tiene su propia concepto "extend" para clases,
pero es eso. Podriamos usa expandir...

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

cortizg and others added 5 commits July 6, 2020 20:25
@cortizg @joaquinelio
Update 1-js/09-classes/02-class-inheritance/article.md
47f058a 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 1-js/09-classes/02-class-inheritance/article.md
67e3918 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 1-js/09-classes/02-class-inheritance/article.md
ec24429 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 1-js/09-classes/02-class-inheritance/article.md
f05f15c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 1-js/09-classes/02-class-inheritance/article.md
caa08db 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg
Copy link
Contributor Author

cortizg commented Jul 7, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 7, 2020 02:28
joaquinelio
joaquinelio approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vamos resolviendo ya casi contemporáneo... ¡pr de hace dos semanas!
Mejor aun , ya superamos el tercio de repo...

@vplentinax vplentinax self-requested a review July 7, 2020 15:41
vplentinax
vplentinax approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@vplentinax vplentinax merged commit 358423e into javascript-tutorial:master Jul 7, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cortizg @javascript-translate-bot @joaquinelio @vplentinax