Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom errors, extending Error #285

Merged
merged 2 commits into from Jun 30, 2020
Merged

Custom errors, extending Error #285

merged 2 commits into from Jun 30, 2020

Conversation

cortizg
Copy link
Contributor

@cortizg cortizg commented Jun 29, 2020

este reemplaza a #184, se cerró por falta de branch

@javascript-translate-bot javascript-translate-bot requested a review from a team June 29, 2020 01:23
@javascript-translate-bot
Copy link

Error: the article already has PR number in the Progress Issue #17, it's 184 ⁉️

@cortizg
Copy link
Contributor Author

cortizg commented Jun 29, 2020

@joaquinelio listo profesor! su vo.bo.!

@iliakan iliakan mentioned this pull request Jun 30, 2020
Open
@joaquinelio joaquinelio self-requested a review June 30, 2020 13:48
joaquinelio
joaquinelio approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A don/doña reviewer+1
Ya pasó por revisión y cambios,
aprobado incluso si no pone el acento en la í que sugerí.

1-js/10-error-handling/2-custom-errors/article.md Outdated Show resolved Hide resolved
@vplentinax @joaquinelio
Update 1-js/10-error-handling/2-custom-errors/article.md
0abe1c0 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax
Copy link
Contributor

/done

@vplentinax vplentinax self-requested a review June 30, 2020 17:18
vplentinax
vplentinax approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge

@vplentinax vplentinax merged commit f69f94e into javascript-tutorial:master Jun 30, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cortizg @javascript-translate-bot @vplentinax @joaquinelio