Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array methods #316

Merged
merged 40 commits into from
Jul 25, 2020
Merged

Array methods #316

merged 40 commits into from
Jul 25, 2020

Conversation

nahuelcoder
Copy link
Contributor

Traducción a español

@javascript-translate-bot javascript-translate-bot requested a review from a team July 22, 2020 22:55
@iliakan iliakan mentioned this pull request Jul 22, 2020
Open
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@joaquinelio joaquinelio self-requested a review July 23, 2020 00:46
@joaquinelio
Copy link
Member

BIENVENIDO @nahuelcoder

disculpa, me anoté pero se me están cruzando los ojos, lo veo mañana...

joaquinelio
joaquinelio requested changes Jul 23, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uf, no terminaba nunca, muchos archivos

Si es tu primera review quizas te sientas tocado por la cantidad de typos
es que uno tiene que aprender que el cerebro nos trampea
y lee lo que quiere leer o lo que cree que dice o lo que produzca menos trabajo.

Sí, nuestro cerebro es más inteligente y perezoso que nosotros.

1-js/05-data-types/05-array-methods/1-camelcase/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/05-array-methods/1-camelcase/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/05-array-methods/11-array-unique/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/05-array-methods/12-reduce-object/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/05-array-methods/12-reduce-object/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/05-array-methods/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/05-array-methods/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/05-array-methods/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/05-array-methods/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/05-array-methods/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

nahuelcoder and others added 8 commits July 23, 2020 16:15
nahuelcoder and others added 15 commits July 23, 2020 16:26
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/9-shuffle/solution.md
bd70974 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
ea5b99c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
a294675 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
28b7b22 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
d047c86 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
0667f15 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
3efcd54 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
5b9c37c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
2792030 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
bfa2c55 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
e62eee8 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
458f3f6 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
5f8f106 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
beba4b1 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder @joaquinelio
Update 1-js/05-data-types/05-array-methods/article.md
b8e291c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@nahuelcoder
Copy link
Contributor Author

/done

joaquinelio
joaquinelio approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES una traducción hermosa, y una de las arduas. 25 archivos.

Puse un suggest a un typo que ses me pasó en la 1ra, quien ms siga que haga clic, no voy a reiniciar ciclo por eso.
Tamb hice trampa, encontré un par ("dos") de tildes y sasbiendo q eran 25 archivos y art de 600 lineas segui de largo, sorry. APROBADO.

Bueno y claro. Buena adición. Come on, reviewers...

1-js/05-data-types/05-array-methods/11-array-unique/solution.md Outdated Show resolved Hide resolved
@vplentinax @joaquinelio
Update 1-js/05-data-types/05-array-methods/11-array-unique/solution.md
b070c86 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
vplentinax
vplentinax approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@nahuelcoder
Copy link
Contributor Author

Muchas gracias por los comentarios y la ayuda con todo lo relacionado a Github, estoy aprendiendo muchísimo!

@joaquinelio
Copy link
Member

Muchas gracias por los comentarios y la ayuda con todo lo relacionado a Github, estoy aprendiendo muchísimo!

Gracias!
La traducción es buena para llevar JS a quienes no saben AÚN (pero deberían) inglés,
pero muchos, como yo, aprendimos GIT aquí...
Acá vi que es importante saberlo
y supongo buen item para el curriculum entender git, estoy tentado a ampliar la explicación al caso de trabajo local.

@joaquinelio
Copy link
Member

joaquinelio commented Jul 25, 2020 •
edited
Loading

Yes @vplentinax

uh, que rápido
no estaras confiando demasiado en mis revisiones, ¿no?
no, no creo. Sabés que a veces patino,

"y mucho".

@joaquinelio joaquinelio merged commit 830ce77 into javascript-tutorial:master Jul 25, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nahuelcoder @CLAassistant @joaquinelio @javascript-translate-bot @vplentinax