Walking the DOM #318

Leired7 · 2020-07-24T14:37:48Z

Artículo, task y soluciones traducido

Traducido "Walking the DOM"

CLAassistant · 2020-07-24T14:37:53Z

All committers have signed the CLA.

joaquinelio

Buena adición al repo,

algún typo,
algún cambio de construcción opinable (que podes ignorar y marcar resuelto)

Esstuve tentado a pedir algo más neutral de "una pega"
pero, argentino, la entendí, es perfecta.

Vamos segundo reviewer, ven a reviegüesear...

EDIT: nota, Don Segundo Reviewer: el bot no lo reconoció, lo agrego a mano. Arreglé el nombre supongo que con DOM mayúsculas lo verá cuando merge. Verificar...

2-ui/1-document/03-dom-navigation/1-dom-children/solution.md

2-ui/1-document/03-dom-navigation/article.md

javascript-translate-bot · 2020-07-24T23:54:47Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

maksumi

Muy buena traducción. Solo arreglar unos tipos y considerar algunas sugerencias para mantener un lenguaje simple en la traducción

2-ui/1-document/03-dom-navigation/1-dom-children/task.md

2-ui/1-document/03-dom-navigation/3-navigation-links-which-null/task.md

2-ui/1-document/03-dom-navigation/article.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

…l/task.md Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Leired7 · 2020-07-27T06:12:51Z

/done

joaquinelio · 2020-07-27T22:59:49Z

@Leired7 ... ¿closed?
Supongo que ya estaba listo para última mirada e integrarlo,
¿puedo suponer que fue un error de "dóndehagoclicahora"? je je tuve muchos de esos cuando empecé con la traducción...

Leired7 · 2020-07-28T06:46:35Z

Síiii @joaquinelio!!!! exactamente paso eso! ¿Dónde "tengoqueclickarahora"?

joaquinelio · 2020-07-28T14:56:01Z

No problem...
El autor puede cerrarlo para modificar sin que nadie lo moleste y reabrirlo o dejarlo cerrado y hacer uno nuevo, no pasa nada.
Acá abajo, "Reopen and comment"...
Pero como dijiste que fuer por error, me tenté y abro y reviso...

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

joaquinelio

No es perfecto, (sutilezas intraducibles)
pero menos será si hacemos de la redacción una asamblea.
Apliqué un par de sug de maksumi, dejé un par afuera, y otra que hice y no supe mejorar.
Funciona como está.

Leired7 · 2020-07-28T19:33:43Z

Muchas gracias por la ayuda ☺️ @joaquinelio

maksumi · 2020-07-28T21:31:21Z

Merge it! Ya llegará el momento de detallar las sutilezas

javascript-translate-bot · 2020-07-29T01:07:31Z

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Leired7 · 2020-07-29T16:24:25Z

¡Qué alegría! jejej Gracias!!!

A por el siguiente....

Leired7 added 7 commits July 24, 2020 16:14

Walking the DOM - Caminando por el DOM

a7e09ce

Traducido "Walking the DOM"

Traducido

b3677bc

Traducido

4a85d1c

Traducido

99a2bcf

Traducido

8d86196

Traducido

62dab4d

Cambiado "niño" por "hijo"

242f006

javascript-translate-bot added the review needed label Jul 24, 2020

joaquinelio self-requested a review July 24, 2020 23:23

joaquinelio requested changes Jul 24, 2020

View reviewed changes

javascript-translate-bot removed the review needed label Jul 24, 2020

javascript-translate-bot added the changes requested label Jul 24, 2020

joaquinelio changed the title ~~Walking the dom~~ Walking the DOM Jul 25, 2020

iliakan mentioned this pull request Jul 25, 2020

Spanish Translation Progress #17

Open

maksumi reviewed Jul 25, 2020

View reviewed changes

Leired7 and others added 13 commits July 27, 2020 07:46

Update 2-ui/1-document/03-dom-navigation/1-dom-children/solution.md

67bd1d3

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/03-dom-navigation/article.md

6cc23a4

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/03-dom-navigation/article.md

6a28723

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/03-dom-navigation/article.md

7fac6f6

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Update 2-ui/1-document/03-dom-navigation/1-dom-children/task.md

bbbd56e

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Update 2-ui/1-document/03-dom-navigation/3-navigation-links-which-nul…

38348d2

…l/task.md Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Update 2-ui/1-document/03-dom-navigation/article.md

c15ada0

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Update 2-ui/1-document/03-dom-navigation/article.md

2e3d02f

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Update 2-ui/1-document/03-dom-navigation/article.md

fbaaed1

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Update 2-ui/1-document/03-dom-navigation/article.md

1501fe9

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Update 2-ui/1-document/03-dom-navigation/article.md

04ec290

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Update 2-ui/1-document/03-dom-navigation/article.md

f416a1c

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Update 2-ui/1-document/03-dom-navigation/article.md

0796f8b

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Leired7 closed this Jul 27, 2020

Leired7 reopened this Jul 27, 2020

Update 2-ui/1-document/03-dom-navigation/article.md

b9880b2

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Leired7 closed this Jul 27, 2020

Leired7 reopened this Jul 27, 2020

Update 2-ui/1-document/03-dom-navigation/1-dom-children/task.md

59135ff

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Leired7 requested a review from joaquinelio July 27, 2020 06:12

javascript-translate-bot added review needed and removed changes requested labels Jul 27, 2020

Leired7 closed this Jul 27, 2020

joaquinelio reopened this Jul 28, 2020

joaquinelio and others added 2 commits July 28, 2020 12:12

Update 2-ui/1-document/03-dom-navigation/article.md

02b92bd

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

Apply suggestions from code review

eb16ae9

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>

joaquinelio approved these changes Jul 28, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels Jul 28, 2020

maksumi approved these changes Jul 28, 2020

View reviewed changes

vplentinax added ready to merge and removed needs +1 labels Jul 29, 2020

vplentinax merged commit 9002711 into javascript-tutorial:master Jul 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Walking the DOM #318

Walking the DOM #318

Leired7 commented Jul 24, 2020

CLAassistant commented Jul 24, 2020 •

edited

Loading

joaquinelio left a comment •

edited

Loading

javascript-translate-bot commented Jul 24, 2020

maksumi left a comment

Leired7 commented Jul 27, 2020

joaquinelio commented Jul 27, 2020

Leired7 commented Jul 28, 2020

joaquinelio commented Jul 28, 2020

joaquinelio left a comment

Leired7 commented Jul 28, 2020

maksumi commented Jul 28, 2020

javascript-translate-bot commented Jul 29, 2020

Leired7 commented Jul 29, 2020

Walking the DOM #318

Walking the DOM #318

Conversation

Leired7 commented Jul 24, 2020

CLAassistant commented Jul 24, 2020 • edited Loading

joaquinelio left a comment • edited Loading

Choose a reason for hiding this comment

javascript-translate-bot commented Jul 24, 2020

maksumi left a comment

Choose a reason for hiding this comment

Leired7 commented Jul 27, 2020

joaquinelio commented Jul 27, 2020

Leired7 commented Jul 28, 2020

joaquinelio commented Jul 28, 2020

joaquinelio left a comment

Choose a reason for hiding this comment

Leired7 commented Jul 28, 2020

maksumi commented Jul 28, 2020

javascript-translate-bot commented Jul 29, 2020

Leired7 commented Jul 29, 2020

CLAassistant commented Jul 24, 2020 •

edited

Loading

joaquinelio left a comment •

edited

Loading