Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutation observer #337

Merged
merged 14 commits into from Aug 9, 2020
Merged

Mutation observer #337

merged 14 commits into from Aug 9, 2020

Conversation

joaquinelio
Copy link
Member

No description provided.

maksumi
maksumi approved these changes Aug 8, 2020
View reviewed changes
Copy link
Collaborator

@maksumi maksumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente traducción. Buen manejo de los conceptos.

Te pasé algunas suggests unas con fundamentos, otras opcionales pero ninguna seria o que entre en conflictos conceptuales... Aún si ninguna te gusta: Approve!

2-ui/99-ui-misc/01-mutation-observer/article.md Show resolved Hide resolved
2-ui/99-ui-misc/01-mutation-observer/article.md Outdated Show resolved Hide resolved
2-ui/99-ui-misc/01-mutation-observer/article.md Outdated Show resolved Hide resolved
2-ui/99-ui-misc/01-mutation-observer/article.md Outdated Show resolved Hide resolved
2-ui/99-ui-misc/01-mutation-observer/article.md Outdated Show resolved Hide resolved
2-ui/99-ui-misc/01-mutation-observer/article.md Outdated Show resolved Hide resolved
2-ui/99-ui-misc/01-mutation-observer/article.md Outdated Show resolved Hide resolved
2-ui/99-ui-misc/01-mutation-observer/article.md Outdated Show resolved Hide resolved
2-ui/99-ui-misc/01-mutation-observer/article.md Outdated Show resolved Hide resolved
2-ui/99-ui-misc/01-mutation-observer/article.md Outdated Show resolved Hide resolved
vplentinax
vplentinax approved these changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Añadiendo lo sugerido por @maksumi y nos vamos!

@joaquinelio
Copy link
Member Author

Añadiendo lo sugerido por @maksumi y nos vamos!

@vplentinax @maksumi
No me convence el cambio a 29.
Bah, dije específicamente "puaj" comfiando en que no se van a ofender...

joaquinelio and others added 13 commits August 8, 2020 21:33
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
6dbfc33
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
f55cdab 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
effe663 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
b633d05 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
e28113d 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
468f325 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
82859a9 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
59392b3 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
e8738ca 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
c57330d 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
c1daaf4 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update 2-ui/99-ui-misc/01-mutation-observer/article.md
0dbe2f0 
266 pero falta refinar

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
refinando los malos consejos de mis partners
2e0cc49
@joaquinelio joaquinelio merged commit 2e02d6d into javascript-tutorial:master Aug 9, 2020
@iliakan iliakan mentioned this pull request Aug 9, 2020
Open
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio joaquinelio deleted the mutation branch August 9, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksumi maksumi maksumi approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joaquinelio @javascript-translate-bot @maksumi @vplentinax