Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class basic syntax #341

Merged
merged 11 commits into from Aug 15, 2020
Merged

Class basic syntax #341

merged 11 commits into from Aug 15, 2020

Conversation

joaquinelio
Copy link
Member

No description provided.

@iliakan iliakan mentioned this pull request Aug 10, 2020
Open
@vplentinax vplentinax self-requested a review August 11, 2020 02:16
EzequielCaste
EzequielCaste requested changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

algunos cambios

1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EzequielCaste EzequielCaste removed the request for review from vplentinax August 14, 2020 03:05
joaquinelio and others added 7 commits August 14, 2020 07:06
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
42005d1 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
93fe7c3 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
ff890cc 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
3c6381a 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
a4247ff 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
cc30582 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio @EzequielCaste
Update 1-js/09-classes/01-class/article.md
aecf331 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@joaquinelio
Copy link
Member Author

/done

@joaquinelio
Copy link
Member Author

Pro primera vez etuve de acuerdo en todo.

y maldita s

maksumi
maksumi approved these changes Aug 15, 2020
View reviewed changes
Copy link
Collaborator

@maksumi maksumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unos pequeños tipos y...
¿Ellas? ¿Quienes?
Jejeje

1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
1-js/09-classes/01-class/article.md Outdated Show resolved Hide resolved
@joaquinelio joaquinelio merged commit 9ba6fe3 into javascript-tutorial:master Aug 15, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio joaquinelio deleted the classbass branch August 15, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksumi maksumi maksumi approved these changes

@EzequielCaste EzequielCaste EzequielCaste approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joaquinelio @javascript-translate-bot @maksumi @EzequielCaste