Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capturing groups #345

Conversation

EzequielCaste
Copy link
Contributor

No description provided.

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por perezoso no verifiqué si hay version mas nueva con ingles
ni si hay más archivos por traducir que estos,
usualmente lo hago como parte del review

Que aburrido que es este tema.
Extraño a @cortizg...

No lo habia leido, me hubiera venido bien lo de matchall y lo de grupo con nombre
este es mi regexp para el api issue17:

/([[\sX]])\s([.+])\s?((http[.\S]+))\s?((@\w+))?\s?(#\d+)?/

bytheway,
en este proyecto no importa para los marcados [X],
pero por esto del formato del match deberias respetar los campos,
al poner 2 autores 2 pr, o cosas ssin los identif que separan los campos, el bot se confundiría.

9-regular-expressions/11-regexp-groups/article.md Outdated Show resolved Hide resolved
9-regular-expressions/11-regexp-groups/article.md Outdated Show resolved Hide resolved
9-regular-expressions/11-regexp-groups/article.md Outdated Show resolved Hide resolved
9-regular-expressions/11-regexp-groups/article.md Outdated Show resolved Hide resolved
9-regular-expressions/11-regexp-groups/article.md Outdated Show resolved Hide resolved
9-regular-expressions/11-regexp-groups/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

EzequielCaste and others added 4 commits August 12, 2020 10:51
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Copy link
Contributor Author

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otro cambio

@joaquinelio
Copy link
Member

@EzequielCaste
"named xxxxxxx"
aparece en arts de
objetos (usaron como vos, "con nombre")
clases
regex

"xxxobjetos/clases/regxx con nombre"
me parece feo, pero por consistencia, te parece, lo dejamos asi ?
decime como lo pones y lo dejo igual en classes

@EzequielCaste
Copy link
Contributor Author

@EzequielCaste
"named xxxxxxx"
aparece en arts de
objetos (usaron como vos, "con nombre")
clases
regex

"xxxobjetos/clases/regxx con nombre"
me parece feo, pero por consistencia, te parece, lo dejamos asi ?
decime como lo pones y lo dejo igual en classes

ok lo dejamos como Grupo con nombre

aunque me gusta más la otra forma...queda más profesional

Copy link
Contributor Author

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listo

@EzequielCaste EzequielCaste merged commit 8082e03 into javascript-tutorial:master Aug 13, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants