Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object to primitive conversion #350

Merged

Conversation

homero304
Copy link
Contributor

Hi, Could you review this PR?
Thanks
Regards,
Homero Marin

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ademas de sugerencias normales,

"hint" no es js, no es programacion, deberiamos traducirlo
No lo hice porque NO entendía qué corno era. (para mi era "pista" que lleva a deduccion, o "inferencia")
cuando convierte, trata de seguir la sugerencia si puede, o si no sabe que otraa cosa hacer,
aunque no me quedo claro de donde viene, parece preprogramadas, no tengo ganas de estudiar

podrias cambiar "hint" o esperar sugerencia de otro reviewer como @maksumi ...

1-js/04-object-basics/09-object-toprimitive/article.md Outdated Show resolved Hide resolved
1-js/04-object-basics/09-object-toprimitive/article.md Outdated Show resolved Hide resolved
1-js/04-object-basics/09-object-toprimitive/article.md Outdated Show resolved Hide resolved
1-js/04-object-basics/09-object-toprimitive/article.md Outdated Show resolved Hide resolved
1-js/04-object-basics/09-object-toprimitive/article.md Outdated Show resolved Hide resolved
1-js/04-object-basics/09-object-toprimitive/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Homero Enrique Marin Galindo and others added 9 commits August 17, 2020 07:29
numérico->número

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
unitario->unario

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
el key simbólico-> la clave simbólica

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
El->Un

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
insinuada->sugerida

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
de lo contrario->en caso contrario

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304
Copy link
Contributor Author

/done

@maksumi
Copy link
Collaborator

maksumi commented Aug 17, 2020

Revisando...

Copy link
Collaborator

@maksumi maksumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Excelente traducción! Salvo algunos detalles desde mi perspectiva, siéntete libre de implementarlos o no.

P.D. Muchos traductores nos dirigimos al lector de manera informal, "tú" y no "usted". Es bajo criterio de cada quién, no estoy seguro si ya se estableció algo al respecto pero creo que mantiene al tutorial amigable con el lector y también sería bueno que fuera uniforme en todos los capítulos para que el lector no se sienta viejo. Mi opinión

1-js/04-object-basics/09-object-toprimitive/article.md Outdated Show resolved Hide resolved
1-js/04-object-basics/09-object-toprimitive/article.md Outdated Show resolved Hide resolved
1-js/04-object-basics/09-object-toprimitive/article.md Outdated Show resolved Hide resolved
Homero Enrique Marin Galindo and others added 3 commits August 18, 2020 19:31
string->strings

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
Entonces->Por lo tanto

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
"`+`"->"El `+`"

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@maksumi
Copy link
Collaborator

maksumi commented Aug 19, 2020

Yo ya aprové... Espereamos el veredicto final de @joaquinelio

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Está bien.
@maksumi @homero304

No me gusta el enfoque inglés, prefiero el de MDN, pero no voy a cambiarlo claro.

hint es solo un argumento interno.
No hay 3 tipos de conversion,
hay 3 tipos de "sugerencias" que la conversion puede usar o no,
hint es solo el "tipo preferido",
default no creo que pueda llamarse un "tipo de conversion".

Bien se podia explicar todo desde el tipo preferido y de alli los casos y apenas mencionar hint.

No pude poner todo eso en una sola frase y que no sea rebuscada.

18 "The conversion is guided by a "preferred type" parameter or "hint" (spec link)...
algo asi

@joaquinelio joaquinelio merged commit 8d28618 into javascript-tutorial:master Aug 19, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@homero304 homero304 deleted the Object-to-primitive-conversion branch August 19, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants