Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greedy and lazy quantifiers #355

Merged
merged 10 commits into from Aug 30, 2020
Merged

Greedy and lazy quantifiers #355

merged 10 commits into from Aug 30, 2020

Conversation

cortizg
Copy link
Contributor

@cortizg cortizg commented Aug 22, 2020

No description provided.

@iliakan iliakan mentioned this pull request Aug 22, 2020
Open
@joaquinelio joaquinelio self-requested a review August 23, 2020 00:31
joaquinelio
joaquinelio requested changes Aug 23, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contento que hayas traducido esto.

En viejos tiempos awkeé, grepeé y egrepeé un monton pero ya no entiendo nada.
fue arduo

9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-tags-greedy-lazy/solution.md Outdated Show resolved Hide resolved
9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-tags-greedy-lazy/solution.md Outdated Show resolved Hide resolved
9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-tags-greedy-lazy/task.md Outdated Show resolved Hide resolved
9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-tags-greedy-lazy/task.md Outdated Show resolved Hide resolved
9-regular-expressions/10-regexp-greedy-and-lazy/article.md Outdated Show resolved Hide resolved
9-regular-expressions/10-regexp-greedy-and-lazy/article.md Outdated Show resolved Hide resolved
9-regular-expressions/10-regexp-greedy-and-lazy/article.md Outdated Show resolved Hide resolved
9-regular-expressions/10-regexp-greedy-and-lazy/article.md Outdated Show resolved Hide resolved
9-regular-expressions/10-regexp-greedy-and-lazy/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

cortizg and others added 9 commits August 23, 2020 11:51
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/article.md
b93e3da 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/article.md
4f36e0c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-ta…
e1987f3 
…gs-greedy-lazy/solution.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-ta…
4b80bdc 
…gs-greedy-lazy/solution.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-ta…
a077326 
…gs-greedy-lazy/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/4-find-html-ta…
920e596 
…gs-greedy-lazy/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/article.md
f4883c3 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/article.md
4b5b44d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/10-regexp-greedy-and-lazy/article.md
fb7a0c4 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg
Copy link
Contributor Author

cortizg commented Aug 23, 2020

/done

joaquinelio
joaquinelio approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprobado
...con una sugerencia extra linea 147

9-regular-expressions/10-regexp-greedy-and-lazy/article.md Show resolved Hide resolved
vplentinax
vplentinax approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codiciosa no me gusta mucho, pero no le veo otra traducción jaja. Está todo bien!
Corregir lo último sugerido por Joa y listo.

@EzequielCaste
Copy link
Contributor

Si @cortizg no aparece, alguien puede corregir lo de "codicioso" por "voraz" ??

@cortizg
Copy link
Contributor Author

cortizg commented Aug 30, 2020

Tendran problemas con el merge, pensé que habian mezclado ya, reinicié mi repo de cero.....

@cortizg
Copy link
Contributor Author

cortizg commented Aug 30, 2020

No puedo hacer el cambio, creo que es por limpiar mi repo

@joaquinelio
Copy link
Member

Ok...
Pero big brother todo lo recuerda...
Merge...

@joaquinelio joaquinelio merged commit 6583bb4 into javascript-tutorial:master Aug 30, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@EzequielCaste EzequielCaste EzequielCaste left review comments

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
changes requested needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cortizg @javascript-translate-bot @EzequielCaste @joaquinelio @vplentinax