Skip to content

Dispatching custom events #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 31, 2020
Merged

Dispatching custom events #363

merged 17 commits into from
Aug 31, 2020

Conversation

homero304
Copy link
Contributor

Hi
Could you review my PR?
Thanks

@joaquinelio joaquinelio self-requested a review August 30, 2020 07:47
joaquinelio
joaquinelio requested changes Aug 30, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta'güeno.
Un paso más a la meta.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

omero329 and others added 8 commits August 30, 2020 13:54
@omero329 @joaquinelio
Update 2-ui/2-events/05-dispatch-events/article.md
4ecec80 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 2-ui/2-events/05-dispatch-events/article.md
d84feae 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 2-ui/2-events/05-dispatch-events/article.md
fa758b0 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 2-ui/2-events/05-dispatch-events/article.md
bd99887 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329
changed to "event.isTrusted es true" instead
ab5ed13
@omero329 @joaquinelio
Update 2-ui/2-events/05-dispatch-events/article.md
e116d39 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329 @joaquinelio
Update 2-ui/2-events/05-dispatch-events/article.md
b80822d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@omero329
Merge branch 'Dispatching-custom-events' of https://github.com/homero…
929bbe6 
…304/es.javascript.info into Dispatching-custom-events
@homero304
Copy link
Contributor Author

/done

homero304
homero304 commented Aug 30, 2020
View reviewed changes
joaquinelio
joaquinelio approved these changes Aug 30, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Nota:
No presto atención a "click" porque ya está extendido,
pero así como no escribiimos "WOF!" cuando ladra un perro, "CLIC" es la onomatopeya correcta en español, no hacia falta que los volvieras al inglés.

EzequielCaste
EzequielCaste requested changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bastante bien 👍 💯

Hice algunas sugerencias, nada grave. Se lee bien y fluido.

Gracias!!

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

omero329 and others added 3 commits August 31, 2020 13:42
@omero329 @EzequielCaste
Update 2-ui/2-events/05-dispatch-events/article.md
e35e2d8 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@omero329 @EzequielCaste
Update 2-ui/2-events/05-dispatch-events/article.md
2116faf 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@omero329 @EzequielCaste
Update 2-ui/2-events/05-dispatch-events/article.md
7057a5a 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
omero329 and others added 2 commits August 31, 2020 13:43
@omero329 @EzequielCaste
Update 2-ui/2-events/05-dispatch-events/article.md
5399dde 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@omero329 @EzequielCaste
Update 2-ui/2-events/05-dispatch-events/article.md
b9dfd9d 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@homero304
Copy link
Contributor Author

/done

@EzequielCaste EzequielCaste merged commit f15313a into javascript-tutorial:master Aug 31, 2020
@iliakan iliakan mentioned this pull request Aug 31, 2020
Open
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@EzequielCaste EzequielCaste EzequielCaste approved these changes

Assignees
No one assigned
Labels
needs +1 review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@homero304 @javascript-translate-bot @joaquinelio @EzequielCaste @omero329