Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch: Cross-Origin Requests #427

Merged
merged 23 commits into from Oct 30, 2020
Merged

Fetch: Cross-Origin Requests #427

merged 23 commits into from Oct 30, 2020

Conversation

MaskeZen
Copy link
Contributor

Se actualiza con la versión en inglés y se traduce el artículo.
Tengo algunas dudas con el término solicitud de "pre-vuelo" y el haber traducido "cross-origin", aunque en el caso de cross-origin, utilicé en un par de casos entre paréntesis el termino en inglés junto a la traducción para que el lector hispano tenga contacto con el termino original.

Espero no de muchos dolores de cabeza la revisión, saludos! 🧉

@javascript-translate-bot javascript-translate-bot requested a review from a team October 19, 2020 02:33
@joaquinelio
Copy link
Member

ooops conflictos... mejor lo veo despues

dont worry, es que la sync está bastante al dia seguro son faciles,
y como decis que te basaste en ingles resuelvo aceptando lo tuyo, deben ser los mismos cambios.

@joaquinelio joaquinelio self-requested a review October 19, 2020 05:38
@joaquinelio
Copy link
Member

Todavia no lo revise, pero veo que tiene 1 ejerccicio tambien prar traducir
task solution
por las dudas: los svg no se tocan, tienen tratamiento especial.

@MaskeZen
Copy link
Contributor Author

Todavia no lo revise, pero veo que tiene 1 ejerccicio tambien prar traducir
task solution
por las dudas: los svg no se tocan, tienen tratamiento especial.

Impecable, ahí agregué esos archivos que se me habían pasado.

joaquinelio
joaquinelio requested changes Oct 22, 2020
View reviewed changes
5-network/05-fetch-crossorigin/1-do-we-need-origin/solution.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio joaquinelio changed the title Cross origin requests Fetch: Cross-Origin Requests Oct 22, 2020
@joaquinelio joaquinelio mentioned this pull request Oct 22, 2020
Open
@joaquinelio
Copy link
Member

corregido nombre pr pa'q bot lo entienda
corregido a issue17 pr427

MaskeZen and others added 12 commits October 22, 2020 22:57
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
538975a 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/1-do-we-need-origin/solution.md
f134240 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
15fe5de 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
769cf76 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
86fa874 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
6cbb169 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
cc63b61 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
5547fd8 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
14f1e35 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen
Update 5-network/05-fetch-crossorigin/article.md
11060b4
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
d2a3367 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
3bdb479 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
MaskeZen and others added 3 commits October 22, 2020 23:18
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
503f717 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
939b5ae 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen @joaquinelio
Update 5-network/05-fetch-crossorigin/article.md
a12276f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@MaskeZen
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team October 23, 2020 02:19
vplentinax
vplentinax requested changes Oct 25, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buena traducción, solo algunas sugerencias.

5-network/05-fetch-crossorigin/1-do-we-need-origin/task.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/05-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio
Copy link
Member

Sí, es terrible.
-prevuelo lo escribiria sin guion, pero no afecta. Y no sé qué tan práctica es la metáfora si se entiende igual.
-no me gustan las redundancias, solicitud - solicitud
-aun hay algun problema de concordacias, ojo la sug de voz pasiva reformulada creo que tamb está mal.
-y por supuesto, las comas medievales de más. Las comas no son para marcar pausas. Batalla que asumo perdida pero siempre lo apunto.

Pero mientras no afecte el concepto, apruebo lo que venga.
Ja ja !!!
está bueno.

Lo leo desp de que revises la revision de Valentina...

MaskeZen and others added 2 commits October 26, 2020 21:28
@MaskeZen @vplentinax
Update Cross-Origin Request javascript-tutorial#427
3114ca5 
Se agregan sugerencias de vplentinax.

Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@MaskeZen
update cross-origin-request
2d4d85f 
Se remueve el es. de las URLs
@MaskeZen
Copy link
Contributor Author

Corté por lo sano y removí los es. de las URLs.

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team October 27, 2020 11:30
@MaskeZen
update cross-origin-request
106425e 
Se remueve el es. de las URLs
joaquinelio
joaquinelio approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Yo creo que es hermoso.

@joaquinelio
Copy link
Member

Por las dudas, entendiste que "es terrible" era un chiste, ¿no?
Me han dicho que chistes, sarcasmos e ironias debo hacerlos explicitos con protocolos tags o emoji
qué gracia asi.

Como sea, aprobemos este bodrio así nos lo sacamos de encima.

@MaskeZen
Copy link
Contributor Author

👍🏽 Sí, lo interpreté en una buena.
Ya casi... jejeje

vplentinax
vplentinax approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki

@joaquinelio joaquinelio merged commit efd631b into javascript-tutorial:master Oct 30, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MaskeZen @joaquinelio @javascript-translate-bot @vplentinax