Skip to content

Interaction: alert, prompt, confirm #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2019
Merged

Interaction: alert, prompt, confirm #49

merged 1 commit into from
May 27, 2019

Conversation

tscandalitta
Copy link
Collaborator

No description provided.

@lizzie136 lizzie136 requested review from lizzie136 and caballerof May 27, 2019 02:37
lizzie136
lizzie136 approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@lizzie136 lizzie136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@lizzie136 lizzie136 merged commit ae9cf98 into javascript-tutorial:master May 27, 2019
@iliakan iliakan mentioned this pull request May 27, 2019
Open
caballerof
caballerof reviewed May 27, 2019
View reviewed changes
Copy link
Collaborator

@caballerof caballerof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deje un par de comentarios para detalles y una propuesta para la traducción de la linea final del texto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizzie136 lizzie136 lizzie136 approved these changes

+1 more reviewer

@caballerof caballerof caballerof left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@maurodibert maurodibert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tscandalitta @lizzie136 @caballerof @maurodibert