Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables #93

Merged
merged 6 commits into from Jun 8, 2020
Merged

Conversation

javier123454321
Copy link

Primera traducción y primera contribución.
Utilizé la segunda persona formal (usted) al referirme al lector del artículo.

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ joaquinelio
✅ ezzep66
❌ Javier Gonzalez


Javier Gonzalez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tscandalitta
Copy link
Collaborator

En el tutorial nos venimos refiriendo al usuario como "tú" y no como "usted". Podrías corregirlo?

@Giorgiosaud
Copy link
Contributor

/done

@javier123454321
Copy link
Author

Lamento la demora, aquí estan estas correcciones, espero poder dedicarle mas tiempo en el futuro cercano y poder progresar mas rápido

Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vplentinax o @ezzep66 Revisen, avisen y lo edito y hago merge
Cierto que faltan los ejercicios, pero
Está buena, no rompe estructura, es largo y tradujo hasta los link externos al sitio ES
Oops! ¿Qué tan importante es firmar eso? ¿Propiedad intelectual?

1-js/02-first-steps/04-variables/article.md Show resolved Hide resolved
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@EzequielCaste
Copy link
Contributor

/done

@vplentinax
Copy link
Contributor

Se puede hacer merge a esto o no¿? @ezzep66 @joaquinelio

1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio joaquinelio merged commit f74c8ae into javascript-tutorial:master Jun 8, 2020
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants