Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operators #19

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Operators #19

merged 2 commits into from
Jul 10, 2019

Conversation

kooshan75
Copy link
Contributor

No description provided.

Copy link
Contributor

@mehradsadeghi mehradsadeghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the article.docx file.
I'm not sure about the translations inside code blocks, because the final result of these translations will be shown RTL and the code blocks will be LTR. So how the Persian characters inside code blocks will be shown ?
Give me your opinion @kooshan75 .

@kooshan75
Copy link
Contributor Author

Please remove the article.docx file.
I'm not sure about the translations inside code blocks, because the final result of these translations will be shown RTL and the code blocks will be LTR. So how the Persian characters inside code blocks will be show ?
Give me your opinion @kooshan75 .

I deleted article.docx file in my first commit. Did I do something wrong?
Ummm, about this RTL thing: I don't think there'd be a problem. Since code blocks are LTR, if there's a Persian comment in those code blocks, it would've been shown correctly, but if there's an English word in between of Persian words, it would mess up the whole sentence. Even in this case, we can easily handle it with adding a js file which fixes these edge cases in code blocks. With all these being said, I can still undo those changes at your request.

@mehradsadeghi mehradsadeghi dismissed their stale review July 10, 2019 12:29

It's not necessary.

@mehradsadeghi mehradsadeghi merged commit e3cfd50 into javascript-tutorial:master Jul 10, 2019
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@mehradsadeghi
Copy link
Contributor

Please remove the article.docx file.
I'm not sure about the translations inside code blocks, because the final result of these translations will be shown RTL and the code blocks will be LTR. So how the Persian characters inside code blocks will be show ?
Give me your opinion @kooshan75 .

I deleted article.docx file in my first commit. Did I do something wrong?
Ummm, about this RTL thing: I don't think there'd be a problem. Since code blocks are LTR, if there's a Persian comment in those code blocks, it would've been shown correctly, but if there's an English word in between of Persian words, it would mess up the whole sentence. Even in this case, we can easily handle it with adding a js file which fixes these edge cases in code blocks. With all these being said, I can still undo those changes at your request.

It's OK. Thank you @kooshan75 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants