-
Notifications
You must be signed in to change notification settings - Fork 9
Sync with upstream @ 97ef8624 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
small reformulations
small reformulation
Reformulations
All operators should return a value because of the definition of the term 'operator'. I could not find an operator as an exception which doesn't return a value. Do you?
In the section describing the usage of `"super"`, example output says `// White Rabbit stands still. White rabbit hides!` The `name` member in this example is set to `White Rabbit`, so the second sentence above should say `White Rabbit hides!` (capital R)
One redundant 'here' here
I think this change will help us to dodge concatenating new arguments with lexical ones and make the currying function much simpler.
Update article.md
Minor output typo
all operators must return a value
Update currying function to use bind instead of wrapper pass
We can declare local variables and give them initial values in parameter list of function definition. So we have another way to create local variables.
parameters are also local variables
It is should be made know that `new.target` is `undefined` for regular function calls than say it is empty.
new.target is undefined not empty
For completeness of the test cases we could add tests for the read method. So every method can have individual test cases.
"exception" vs "new feature" ?
Missing word / small fix.
Spelling error: 'out'-->'our' Idiom: 'From the other hand'-->"On the other hand"
Spelling error & wrong idiom
Update article.md
too wordy explanation
Fix mismatched alert text
In the original it's read as if there is two rabbit methods, instead of "both to... and also to..."
to both -> both to
modify alternative method in comment of mixins' code example
|
This PR was automatically generated to merge changes from en.javascript.info at 97ef862
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
git checkout master
git pull upstream master
git checkout --ours <path>
git diff --word-diff master...upstream/master <path>
(please note: three dots in the command)git push origin master
This PR will be closed and replaced with a new one in a few days.