Skip to content

Conversation

javascript-translate-bot

This PR was automatically generated to merge changes from en.javascript.info at 97ef862

Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.

Alternatively, you can close this PR and merge conflicting changes manually.

The following files have conflicts and may need updates of the translations:

To merge changes manually (instead of merging this PR):

  1. Add remote upstream that links to the English version (only needs to be done once)
    • git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
  2. Commit all current work locally and git checkout master
  3. Pull the recent changes from the English version:
    • git pull upstream master
  4. Deal with the conflicts. If a conflict touches a few lines, then just fix it. Otherwise, following commands can help:
    • Checkout your (translated) version of a file/folder at the given path (removes all upstream changes):
      • git checkout --ours <path>
    • See the diff, what changed in the upstream file since branches diverged:
      • git diff --word-diff master...upstream/master <path> (please note: three dots in the command)
    • Then you can examine the changes in upstream and add them manually
  5. When conflicts resolved, commit them and git push origin master

This PR will be closed and replaced with a new one in a few days.

RapTho and others added 30 commits December 14, 2020 16:19
All operators should return a value because of the definition of the term 'operator'. 
I could not find an operator as an exception which doesn't return a value.
Do you?
In the section describing the usage of `"super"`, example output says `// White Rabbit stands still. White rabbit hides!`

The `name` member in this example is set to `White Rabbit`, so the second sentence above should say `White Rabbit hides!` (capital R)
One redundant 'here' here
I think this change will help us to dodge concatenating new arguments with lexical ones and make the currying function much simpler.
all operators must return a value
Update currying function to use bind instead of wrapper pass
We can declare local variables and give them initial values in parameter list of function definition. So we have another way to create local variables.
parameters are also local variables
It is should be made know that `new.target` is `undefined` for regular function calls than say it is empty.
For completeness of the test cases we could add tests for the read method. So every method can have individual test cases.
@CLAassistant
Copy link

CLAassistant commented Jan 25, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 14 committers have signed the CLA.

✅ joaquinelio
✅ iliakan
✅ msisaifu
❌ lumosmind
❌ RapTho
❌ bilalbutt044
❌ TaylorClay
❌ martynov-94
❌ lapstjup
❌ AmosChenYQ
❌ sarscode
❌ emek
❌ bierlingm
❌ redrambles
You have signed the CLA already but the status is still pending? Let us recheck it.

@szcsl szcsl merged commit 265b43e into master Jan 25, 2021
@szcsl szcsl deleted the sync-97ef8624 branch January 25, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.