Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hello, world! #28

Merged
merged 20 commits into from
Sep 1, 2019
Merged

Hello, world! #28

merged 20 commits into from
Sep 1, 2019

Conversation

kaddopur
Copy link
Contributor

Target chapter

1-js/01-getting-started/1-intro

Modified files

File name Change（reason）
article.md 翻譯繁體中文
1-task-folder/* 翻譯繁體中文

@javascript-translate-bot javascript-translate-bot requested a review from a team August 31, 2019 03:38
@iliakan iliakan mentioned this pull request Aug 31, 2019
Open
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

ArvinH
ArvinH previously approved these changes Aug 31, 2019
View reviewed changes
lenchen1112
lenchen1112 requested changes Aug 31, 2019
View reviewed changes
Copy link
Contributor

@lenchen1112 lenchen1112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

生哥根本對岸來的吧，對岸用語超多

1-js/02-first-steps/01-hello-world/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/01-hello-world/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/01-hello-world/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/01-hello-world/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/01-hello-world/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/01-hello-world/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/01-hello-world/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/01-hello-world/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/01-hello-world/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/01-hello-world/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
e1c4164 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
kaddopur and others added 11 commits August 31, 2019 16:04
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
88f4159 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
50ec945 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
cb31764 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
0a10a71 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
ac0ad11 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
31abce2 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
06e8c6f 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
ae3c3c7 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
6582a9d 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
34d7406 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
f938e84 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
kaddopur and others added 3 commits August 31, 2019 16:09
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
d7154f8 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
3cb9ba4 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
@kaddopur @lenchen1112
Update 1-js/02-first-steps/01-hello-world/article.md
8c6056d 
Co-Authored-By: Len Chen <lenchen1112@users.noreply.github.com>
ArvinH
ArvinH approved these changes Sep 1, 2019
View reviewed changes
1-js/02-first-steps/01-hello-world/article.md

Other pages that reference the same script will take it from the cache instead of downloading it, so the file is actually downloaded only once.
而當其他頁面需要使用同一份腳本時，就會省略下載而從快取中拿取，這個腳本實際上只被下載了一次。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
而當其他頁面需要使用同一份腳本時，就會省略下載而從快取中拿取，這個腳本實際上只被下載了一次。
而當其他頁面需要使用同一份腳本時，就會省略下載而從快取中拿取，因此這個腳本實際上只被下載了一次。

@kaddopur kaddopur merged commit 9657d50 into javascript-tutorial:master Sep 1, 2019
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@kaddopur kaddopur deleted the hello_world branch September 1, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArvinH ArvinH ArvinH approved these changes

@lenchen1112 lenchen1112 lenchen1112 approved these changes

Assignees

@kaddopur kaddopur

Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kaddopur @CLAassistant @javascript-translate-bot @ArvinH @lenchen1112