Skip to content

Comments #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2019
Merged

Comments #44

merged 2 commits into from
Sep 29, 2019

Conversation

lenchen1112
Copy link
Contributor

Target chapter

1-js/03-code-quality/03-comments

Modified files

File name Change（reason）
article.md 翻譯繁體中文

@lenchen1112 lenchen1112 requested a review from a team September 12, 2019 03:12
@lenchen1112 lenchen1112 self-assigned this Sep 12, 2019
@iliakan iliakan mentioned this pull request Sep 12, 2019
Open
kaddopur
kaddopur reviewed Sep 16, 2019
View reviewed changes
kaddopur
kaddopur reviewed Sep 16, 2019
View reviewed changes
kaddopur
kaddopur reviewed Sep 16, 2019
View reviewed changes
ArvinH
ArvinH approved these changes Sep 17, 2019
View reviewed changes
@lenchen1112 @kaddopur @ArvinH
Apply suggestions from code review
4102f01 
Co-Authored-By: Jason Huang <chaoju.huang@gmail.com>
Co-Authored-By: ArvinH <arvin0731@gmail.com>
@lenchen1112
Copy link
Contributor Author

@kaddopur

@lenchen1112 lenchen1112 merged commit cff5242 into javascript-tutorial:master Sep 29, 2019
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArvinH ArvinH ArvinH approved these changes

@kaddopur kaddopur kaddopur approved these changes

Assignees

@lenchen1112 lenchen1112

Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lenchen1112 @javascript-translate-bot @ArvinH @kaddopur