Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objects #52

Merged
merged 5 commits into from
Oct 12, 2019
Merged

Objects #52

merged 5 commits into from
Oct 12, 2019

Conversation

lenchen1112
Copy link
Contributor

Target chapter

1-js/04-object-basics/01-object

Modified files

File name Change（reason）
article.md 翻譯繁體中文
2-hello-object/* 翻譯繁體中文
3-is-empty/* 翻譯繁體中文
5-sum-object/* 翻譯繁體中文
8-multiply-numeric/* 翻譯繁體中文

@lenchen1112 lenchen1112 requested a review from a team September 29, 2019 09:31
@lenchen1112 lenchen1112 self-assigned this Sep 29, 2019
@iliakan iliakan mentioned this pull request Sep 29, 2019
Open
@lenchen1112 @ArvinH
Apply suggestions from code review
519d954 
Co-Authored-By: ArvinH <arvin0731@gmail.com>
ArvinH
ArvinH reviewed Oct 2, 2019
View reviewed changes
1-js/04-object-basics/01-object/article.md
In the code above, the property `obj.test` technically exists. So the `in` operator works right.

Situations like this happen very rarely, because `undefined` is usually not assigned. We mostly use `null` for "unknown" or "empty" values. So the `in` operator is an exotic guest in the code.
類似的情況非常少發生，因為 `undefined` 通常不會被指定，我們對於 "未知" 或 "空白" 的值大多會使用 `null`，所以 `in` 運算子可以算是程式碼的過客。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exotic guest 也太難翻...過客感覺有點怪，但也想不到更好的 lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaddopur @tom76kimo 來來來一起想想要怎麼翻比較好

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我覺得可以

@lenchen1112 lenchen1112 merged commit e5e4edb into javascript-tutorial:master Oct 12, 2019
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArvinH ArvinH ArvinH approved these changes

@tom76kimo tom76kimo tom76kimo approved these changes

Assignees

@lenchen1112 lenchen1112

Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lenchen1112 @javascript-translate-bot @ArvinH @tom76kimo