♻️ refactor: refactor message create name (lobehub#10074)

arvinxx · web-flow · commit 08ec29f3a293 · 2025-11-06T13:41:01.000+08:00
refactor name
diff --git a/src/server/routers/lambda/__tests__/integration/message.integration.test.ts b/src/server/routers/lambda/__tests__/integration/message.integration.test.ts
diff --git a/src/server/routers/lambda/message.ts b/src/server/routers/lambda/message.ts
@@ -54,11 +54,11 @@ export const messageRouter = router({
       return ctx.messageModel.countWords(input);
     }),
 
-  createNewMessage: messageProcedure
+  createMessage: messageProcedure
     .input(CreateNewMessageParamsSchema.extend({ useGroup: z.boolean().optional() }))
     .mutation(async ({ input, ctx }) => {
       const { useGroup, ...params } = input;
-      return ctx.messageService.createNewMessage(params as any, { useGroup });
+      return ctx.messageService.createMessage(params as any, { useGroup });
     }),
 
   getHeatmaps: messageProcedure.query(async ({ ctx }) => {
diff --git a/src/server/services/message/__tests__/index.test.ts b/src/server/services/message/__tests__/index.test.ts
@@ -255,7 +255,7 @@ describe('MessageService', () => {
     });
   });
 
-  describe('createNewMessage', () => {
+  describe('createMessage', () => {
     it('should create message and return message list', async () => {
       const params = {
         content: 'Hello',
@@ -268,7 +268,7 @@ describe('MessageService', () => {
       vi.mocked(mockMessageModel.create).mockResolvedValue(createdMessage as any);
       vi.mocked(mockMessageModel.query).mockResolvedValue(mockMessages as any);
 
-      const result = await messageService.createNewMessage(params as any);
+      const result = await messageService.createMessage(params as any);
 
       expect(mockMessageModel.create).toHaveBeenCalledWith(params);
       expect(mockMessageModel.query).toHaveBeenCalledWith(
@@ -301,7 +301,7 @@ describe('MessageService', () => {
       vi.mocked(mockMessageModel.create).mockResolvedValue(createdMessage as any);
       vi.mocked(mockMessageModel.query).mockResolvedValue(mockMessages as any);
 
-      const result = await messageService.createNewMessage(params as any, { useGroup: true });
+      const result = await messageService.createMessage(params as any, { useGroup: true });
 
       expect(mockMessageModel.query).toHaveBeenCalledWith(
         expect.anything(),
@@ -329,7 +329,7 @@ describe('MessageService', () => {
       vi.mocked(mockMessageModel.create).mockResolvedValue(createdMessage as any);
       vi.mocked(mockMessageModel.query).mockResolvedValue(mockMessages as any);
 
-      const result = await messageService.createNewMessage(params as any);
+      const result = await messageService.createMessage(params as any);
 
       expect(mockMessageModel.query).toHaveBeenCalledWith(
         {
diff --git a/src/server/services/message/index.ts b/src/server/services/message/index.ts
@@ -128,7 +128,7 @@ export class MessageService {
    * This method combines message creation and querying into a single operation,
    * reducing the need for separate refresh calls and improving performance.
    */
-  async createNewMessage(
+  async createMessage(
     params: CreateMessageParams,
     options?: QueryOptions,
   ): Promise<CreateMessageResult> {
diff --git a/src/services/message/index.ts b/src/services/message/index.ts
@@ -23,11 +23,11 @@ export class MessageService {
     return labPreferSelectors.enableAssistantMessageGroup(useUserStore.getState());
   }
 
-  createNewMessage = async ({
+  createMessage = async ({
     sessionId,
     ...params
   }: CreateMessageParams): Promise<CreateMessageResult> => {
-    return lambdaClient.message.createNewMessage.mutate({
+    return lambdaClient.message.createMessage.mutate({
       ...params,
       sessionId: sessionId ? this.toDbSessionId(sessionId) : undefined,
       useGroup: this.useGroup,
diff --git a/src/store/chat/slices/aiChat/actions/__tests__/generateAIChat.test.ts b/src/store/chat/slices/aiChat/actions/__tests__/generateAIChat.test.ts
@@ -61,7 +61,7 @@ describe('chatMessage actions', () => {
           await result.current.sendMessage({ message: TEST_CONTENT.USER_MESSAGE });
         });
 
-        expect(messageService.createNewMessage).not.toHaveBeenCalled();
+        expect(messageService.createMessage).not.toHaveBeenCalled();
         expect(result.current.internal_coreProcessMessage).not.toHaveBeenCalled();
       });
 
@@ -72,7 +72,7 @@ describe('chatMessage actions', () => {
           await result.current.sendMessage({ message: TEST_CONTENT.EMPTY });
         });
 
-        expect(messageService.createNewMessage).not.toHaveBeenCalled();
+        expect(messageService.createMessage).not.toHaveBeenCalled();
       });
 
       it('should not send when message is empty with empty files array', async () => {
@@ -82,7 +82,7 @@ describe('chatMessage actions', () => {
           await result.current.sendMessage({ message: TEST_CONTENT.EMPTY, files: [] });
         });
 
-        expect(messageService.createNewMessage).not.toHaveBeenCalled();
+        expect(messageService.createMessage).not.toHaveBeenCalled();
       });
     });
 
@@ -97,13 +97,13 @@ describe('chatMessage actions', () => {
           });
         });
 
-        expect(messageService.createNewMessage).toHaveBeenCalled();
+        expect(messageService.createMessage).toHaveBeenCalled();
         expect(result.current.internal_coreProcessMessage).not.toHaveBeenCalled();
       });
 
       it('should handle message creation errors gracefully', async () => {
         const { result } = renderHook(() => useChatStore());
-        vi.spyOn(messageService, 'createNewMessage').mockRejectedValue(
+        vi.spyOn(messageService, 'createMessage').mockRejectedValue(
           new Error('create message error'),
         );
 
@@ -229,7 +229,7 @@ describe('chatMessage actions', () => {
         .mockResolvedValue({ isFunctionCall: false, content: 'AI response' });
 
       const createMessageSpy = vi
-        .spyOn(messageService, 'createNewMessage')
+        .spyOn(messageService, 'createMessage')
         .mockResolvedValue({ id: TEST_IDS.ASSISTANT_MESSAGE_ID, messages: mockMessages });
 
       const replaceMessagesSpy = vi.spyOn(result.current, 'replaceMessages');
@@ -272,7 +272,7 @@ describe('chatMessage actions', () => {
           rewriteQuery: 'rewritten query',
         });
 
-      vi.spyOn(messageService, 'createNewMessage').mockResolvedValue({
+      vi.spyOn(messageService, 'createMessage').mockResolvedValue({
         id: TEST_IDS.ASSISTANT_MESSAGE_ID,
         messages: [],
       });
@@ -306,7 +306,7 @@ describe('chatMessage actions', () => {
         .spyOn(result.current, 'internal_fetchAIChatMessage')
         .mockResolvedValue({ isFunctionCall: false, content: '' });
 
-      vi.spyOn(messageService, 'createNewMessage').mockResolvedValue(undefined as any);
+      vi.spyOn(messageService, 'createMessage').mockResolvedValue(undefined as any);
 
       await act(async () => {
         await result.current.internal_coreProcessMessage([userMessage], userMessage.id);
diff --git a/src/store/chat/slices/aiChat/actions/__tests__/generateAIChatV2.test.ts b/src/store/chat/slices/aiChat/actions/__tests__/generateAIChatV2.test.ts
@@ -131,7 +131,7 @@ describe('generateAIChatV2 actions', () => {
           await result.current.sendMessage({ message: TEST_CONTENT.USER_MESSAGE });
         });
 
-        expect(messageService.createNewMessage).not.toHaveBeenCalled();
+        expect(messageService.createMessage).not.toHaveBeenCalled();
         expect(result.current.internal_execAgentRuntime).not.toHaveBeenCalled();
       });
 
@@ -142,7 +142,7 @@ describe('generateAIChatV2 actions', () => {
           await result.current.sendMessage({ message: TEST_CONTENT.EMPTY });
         });
 
-        expect(messageService.createNewMessage).not.toHaveBeenCalled();
+        expect(messageService.createMessage).not.toHaveBeenCalled();
       });
 
       it('should not send when message is empty with empty files array', async () => {
@@ -152,7 +152,7 @@ describe('generateAIChatV2 actions', () => {
           await result.current.sendMessage({ message: TEST_CONTENT.EMPTY, files: [] });
         });
 
-        expect(messageService.createNewMessage).not.toHaveBeenCalled();
+        expect(messageService.createMessage).not.toHaveBeenCalled();
       });
     });
 
@@ -312,7 +312,7 @@ describe('generateAIChatV2 actions', () => {
           });
         });
 
-        expect(messageService.createNewMessage).toHaveBeenCalled();
+        expect(messageService.createMessage).toHaveBeenCalled();
         expect(result.current.internal_execAgentRuntime).not.toHaveBeenCalled();
       });
 
@@ -749,7 +749,7 @@ describe('generateAIChatV2 actions', () => {
 
     beforeEach(() => {
       // Reset mocks
-      vi.spyOn(messageService, 'createNewMessage').mockResolvedValue({
+      vi.spyOn(messageService, 'createMessage').mockResolvedValue({
         id: 'new-assistant-block-id',
         messages: [] as any,
       });
@@ -814,8 +814,8 @@ describe('generateAIChatV2 actions', () => {
         }),
       );
 
-      // Verify that createNewMessage was called with message params
-      expect(messageService.createNewMessage).toHaveBeenCalledWith(
+      // Verify that createMessage was called with message params
+      expect(messageService.createMessage).toHaveBeenCalledWith(
         expect.objectContaining({
           role: 'assistant',
           parentId: TOOL_RESULT_MSG_ID,
@@ -866,7 +866,7 @@ describe('generateAIChatV2 actions', () => {
         }),
       );
 
-      expect(messageService.createNewMessage).toHaveBeenCalledWith(
+      expect(messageService.createMessage).toHaveBeenCalledWith(
         expect.objectContaining({
           role: 'assistant',
           parentId: 'non-existent-tool-result-id',
diff --git a/src/store/chat/slices/aiChat/actions/__tests__/helpers.ts b/src/store/chat/slices/aiChat/actions/__tests__/helpers.ts
@@ -58,7 +58,7 @@ export const createMockAbortController = () => {
  */
 export const spyOnMessageService = () => {
   const createMessageSpy = vi
-    .spyOn(messageService, 'createNewMessage')
+    .spyOn(messageService, 'createMessage')
     .mockResolvedValue({ id: TEST_IDS.NEW_MESSAGE_ID, messages: [] });
   const updateMessageSpy = vi
     .spyOn(messageService, 'updateMessage')
diff --git a/src/store/chat/slices/aiChat/actions/generateAIChatV2.ts b/src/store/chat/slices/aiChat/actions/generateAIChatV2.ts
@@ -646,7 +646,7 @@ export const generateAIChatV2: StateCreator<
           payload.type,
         );
 
-        // 2. 使用 createNewMessage 创建 tool 消息
+        // 2. 使用 createMessage 创建 tool 消息
         const toolMessage: CreateNewMessageParams = {
           content: '',
           parentId: assistantId,
diff --git a/src/store/chat/slices/message/action.test.ts b/src/store/chat/slices/message/action.test.ts
@@ -25,7 +25,7 @@ vi.mock('@/services/message', () => ({
     removeMessage: vi.fn(),
     removeMessagesByAssistant: vi.fn(),
     removeMessages: vi.fn(() => Promise.resolve()),
-    createNewMessage: vi.fn(() => Promise.resolve({ id: 'new-message-id', messages: [] })),
+    createMessage: vi.fn(() => Promise.resolve({ id: 'new-message-id', messages: [] })),
     updateMessage: vi.fn(),
     removeAllMessages: vi.fn(() => Promise.resolve()),
   },
@@ -71,7 +71,7 @@ describe('chatMessage actions', () => {
         await result.current.addAIMessage();
       });
 
-      expect(messageService.createNewMessage).not.toHaveBeenCalled();
+      expect(messageService.createMessage).not.toHaveBeenCalled();
       expect(updateInputMessageSpy).not.toHaveBeenCalled();
     });
 
@@ -84,7 +84,7 @@ describe('chatMessage actions', () => {
         await result.current.addAIMessage();
       });
 
-      expect(messageService.createNewMessage).toHaveBeenCalledWith({
+      expect(messageService.createMessage).toHaveBeenCalledWith({
         content: inputMessage,
         role: 'assistant',
         sessionId: mockState.activeId,
@@ -113,7 +113,7 @@ describe('chatMessage actions', () => {
         await result.current.addUserMessage({ message: 'test message' });
       });
 
-      expect(messageService.createNewMessage).not.toHaveBeenCalled();
+      expect(messageService.createMessage).not.toHaveBeenCalled();
       expect(updateInputMessageSpy).not.toHaveBeenCalled();
     });
 
@@ -130,7 +130,7 @@ describe('chatMessage actions', () => {
         await result.current.addUserMessage({ message, fileList });
       });
 
-      expect(messageService.createNewMessage).toHaveBeenCalledWith({
+      expect(messageService.createMessage).toHaveBeenCalledWith({
         content: message,
         files: fileList,
         role: 'user',
@@ -154,7 +154,7 @@ describe('chatMessage actions', () => {
         await result.current.addUserMessage({ message });
       });
 
-      expect(messageService.createNewMessage).toHaveBeenCalledWith({
+      expect(messageService.createMessage).toHaveBeenCalledWith({
         content: message,
         files: undefined,
         role: 'user',
@@ -184,7 +184,7 @@ describe('chatMessage actions', () => {
         await result.current.addUserMessage({ message });
       });
 
-      expect(messageService.createNewMessage).toHaveBeenCalledWith({
+      expect(messageService.createMessage).toHaveBeenCalledWith({
         content: message,
         files: undefined,
         role: 'user',
diff --git a/src/store/chat/slices/message/action.ts b/src/store/chat/slices/message/action.ts
@@ -519,10 +519,10 @@ export const chatMessage: StateCreator<
     }
 
     try {
-      const result = await messageService.createNewMessage(message);
+      const result = await messageService.createMessage(message);
 
       if (!context?.skipRefresh) {
-        // Use the messages returned from createNewMessage (already grouped)
+        // Use the messages returned from createMessage (already grouped)
         replaceMessages(result.messages);
       }
 
diff --git a/src/store/chat/slices/plugin/action.test.ts b/src/store/chat/slices/plugin/action.test.ts
@@ -26,7 +26,7 @@ vi.mock('@/services/message', () => ({
     updateMessageError: vi.fn(),
     updateMessagePluginState: vi.fn(),
     updateMessagePluginArguments: vi.fn(),
-    createNewMessage: vi.fn(),
+    createMessage: vi.fn(),
   },
 }));
 
@@ -565,8 +565,8 @@ describe('ChatPluginAction', () => {
   describe('createAssistantMessageByPlugin', () => {
     it('should create an assistant message and replace messages', async () => {
       const mockMessages = [{ id: 'msg-1', content: 'test' }] as any;
-      // 模拟 messageService.createNewMessage 方法的实现
-      (messageService.createNewMessage as Mock).mockResolvedValue({
+      // 模拟 messageService.createMessage 方法的实现
+      (messageService.createMessage as Mock).mockResolvedValue({
         id: 'new-message-id',
         messages: mockMessages,
       });
@@ -588,8 +588,8 @@ describe('ChatPluginAction', () => {
         await result.current.createAssistantMessageByPlugin(content, parentId);
       });
 
-      // 验证 messageService.createNewMessage 是否被带有正确参数调用
-      expect(messageService.createNewMessage).toHaveBeenCalledWith({
+      // 验证 messageService.createMessage 是否被带有正确参数调用
+      expect(messageService.createMessage).toHaveBeenCalledWith({
         content,
         parentId,
         role: 'assistant',
@@ -604,7 +604,7 @@ describe('ChatPluginAction', () => {
     it('should handle errors when message creation fails', async () => {
       // 模拟 messageService.create 方法，使其抛出错误
       const errorMessage = 'Failed to create message';
-      (messageService.createNewMessage as Mock).mockRejectedValue(new Error(errorMessage));
+      (messageService.createMessage as Mock).mockRejectedValue(new Error(errorMessage));
 
       // 设置初始状态并模拟 refreshMessages 方法
       const initialState = {
@@ -626,7 +626,7 @@ describe('ChatPluginAction', () => {
       });
 
       // 验证 messageService.create 是否被带有正确参数调用
-      expect(messageService.createNewMessage).toHaveBeenCalledWith({
+      expect(messageService.createMessage).toHaveBeenCalledWith({
         content,
         parentId,
         role: 'assistant',
diff --git a/src/store/chat/slices/plugin/action.ts b/src/store/chat/slices/plugin/action.ts
@@ -98,7 +98,7 @@ export const chatPlugin: StateCreator<
       topicId: get().activeTopicId, // if there is activeTopicId，then add it to topicId
     };
 
-    const result = await messageService.createNewMessage(newMessage);
+    const result = await messageService.createMessage(newMessage);
     get().replaceMessages(result.messages);
   },
 
