Skip to content

Conversation

gytis
Copy link
Contributor

@gytis gytis commented Jan 28, 2014

No description provided.

@jbosstm-bot
Copy link

Started testing this pull request: http://172.17.131.2/job/btny-pulls-quickstart/22/

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't these need to be STM counters for this to be truly transactional? If you rollback the number will still be incremented. I think the CDI bean should be using a JMS resource instead.

@gytis
Copy link
Contributor Author

gytis commented Feb 13, 2014

@tomjenkinson, so maybe I should rework this QS to have both JPA and JMS?

@tomjenkinson
Copy link
Member

You could use a dummy XAResource, but yes, you certainly need two XAResources

@gytis gytis closed this Feb 13, 2014
@gytis gytis reopened this Feb 13, 2014
@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

Started testing this pull request: http://172.17.131.2/job/btny-pulls-quickstart/23/

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

Started testing this pull request: http://172.17.131.2/job/btny-pulls-quickstart/24/

@jbosstm-bot
Copy link

@tomjenkinson
Copy link
Member

Is this ready for review? I noticed on the Jira it is status of PR sent, do you want me to review it?

@gytis
Copy link
Contributor Author

gytis commented Feb 17, 2014

Please do. I've changed it to use JPA and JMS. Also added simple POJO to show @TransactionScoped

@tomjenkinson
Copy link
Member

Looks good to merge - thanks!

@gytis gytis merged commit 1303482 into jbosstm:master Feb 17, 2014
@gytis gytis deleted the master-JBTM-2050.JTA_1.2_annotations_QS_inside_WildFly branch April 8, 2014 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants