-
Notifications
You must be signed in to change notification settings - Fork 109
JBTM-2050. JTA 1.2 annotations inside WildFly quickstart #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBTM-2050. JTA 1.2 annotations inside WildFly quickstart #116
Conversation
Started testing this pull request: http://172.17.131.2/job/btny-pulls-quickstart/22/ |
Starting tests http://172.17.131.2/job/btny-pulls-quickstart-taconic/634/ |
Pull passed: http://172.17.131.2/job/btny-pulls-quickstart/22/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't these need to be STM counters for this to be truly transactional? If you rollback the number will still be incremented. I think the CDI bean should be using a JMS resource instead.
@tomjenkinson, so maybe I should rework this QS to have both JPA and JMS? |
You could use a dummy XAResource, but yes, you certainly need two XAResources |
Starting tests http://172.17.131.2/job/btny-pulls-quickstart-taconic/635/ |
Started testing this pull request: http://172.17.131.2/job/btny-pulls-quickstart/23/ |
Pull passed: http://172.17.131.2/job/btny-pulls-quickstart/23/ |
Starting tests http://172.17.131.2/job/btny-pulls-quickstart-taconic/636/ |
Started testing this pull request: http://172.17.131.2/job/btny-pulls-quickstart/24/ |
Pull passed: http://172.17.131.2/job/btny-pulls-quickstart/24/ |
Is this ready for review? I noticed on the Jira it is status of PR sent, do you want me to review it? |
Please do. I've changed it to use JPA and JMS. Also added simple POJO to show @TransactionScoped |
Looks good to merge - thanks! |
No description provided.