Migrate the SRA demo package (io.narayana.sra.demo) over to the [quic… #434

moulalis · 2023-04-10T14:42:53Z

Issue: https://issues.redhat.com/browse/JBTM-3462
Issue: https://issues.redhat.com/browse/JBTM-3463
Issue: https://issues.redhat.com/browse/JBTM-3794

The PR https://issues.redhat.com/browse/JBTM-3489 is fixed. So it is available for review.

mmusgrov · 2023-04-11T08:57:06Z

Where are the quickstart instructions?
Do we still have the problem of filters not getting registered?
The PR, as it stands, is incomplete and perhaps needs to be withdrawn.

moulalis · 2023-04-11T09:03:10Z

Where are the quickstart instructions? Do we still have the problem of filters not getting registered? The PR, as it stands, is incomplete and perhaps needs to be withdrawn.

Hi @mmusgrov, This is Draft PR, it is not ready for review.

mmusgrov · 2023-04-11T10:20:45Z

What is the purpose of this PR if it's not a request to merge a fix into the codebase?

mmusgrov · 2023-04-11T10:22:39Z

What is the purpose of this PR if it's not a request to merge a fix into the codebase?
When you raise a PR various engineers get email notifications that they should review the request so if you raise one before it's ready then it just adds workload to the requested engineers.

moulalis · 2023-04-11T18:52:24Z

PR is ready for review.
Thanks.

rts/at/sra/src/main/java/io/narayana/sra/demo/api/HotelController.java

rts/at/sra/src/main/java/io/narayana/sra/demo/api/FlightController.java

rts/at/sra/src/main/java/io/narayana/sra/demo/api/TripController.java

marcosgopen · 2023-04-12T09:23:01Z

Thank you @moulalis for your PR. I wonder if the sra module should go under rts/at/ (as Moulali proposed) or under rts/ folder like lra module. WDYT @mmusgrov ?

mmusgrov · 2023-04-12T09:41:39Z

Thank you @moulalis for your PR. I wonder if the sra module should go under rts/at/ (as Moulali proposed) or under rts/ folder like lra module. WDYT @mmusgrov ?

SRA is synonymous with REST-AT - it's just a different name for it. The SRA demo is to showcase how to use the REST-AT annotations so it belongs with the at module. I called it SRA to complement LRA when I proposed the model to the MP Eclipse organisation - MP projects are annotation based so that's why I needed to add them for REST-AT which currently only offers a pure REST API. If people think it is going to cause confusion we could change the name but TBH the name SRA seems like a good fit for the annotation API layered over the REST API.

mmusgrov

We have lost a record of the work that other contributors (such as Sweta and Ondra) made to the module (git log --follow should be able to track the moved files).

rts/at/sra/README.md

rts/at/sra/pom.xml

rts/at/sra/src/main/java/io/narayana/sra/demo/api/FlightController.java

mmusgrov · 2023-04-12T10:37:56Z

@moulalis I don't think we should merge this until we have fixed the demo ie issue https://issues.redhat.com/browse/JBTM-3489 should be resolved first. If we were to merge this first then JBTM-3489 would need to be marked as a blocker.

I've linked the two issues.

mmusgrov · 2023-04-12T10:50:22Z

Resolving JBTM-3463 would also significantly improve this quickstart

marcosgopen · 2023-04-12T13:01:45Z

Resolving JBTM-3463 would also significantly improve this quickstart

Yes, I agree with Mike. It would be great to resolve all the issues related to the SRA quickstart (same PR but different commits). I understand it might be quite demanding, so if you need help we will be happy to help.

mmusgrov · 2023-04-13T08:16:44Z

Resolving JBTM-3463 would also significantly improve this quickstart

Actually, working on this issue could be a follow up quickstart showing how to decompose the example into separate microservices and also showing how the context still gets propagated.

moulalis · 2023-04-13T10:38:19Z

Resolving JBTM-3463 would also significantly improve this quickstart

Actually, working on this issue could be a follow up quickstart showing how to decompose the example into separate microservices and also showing how the context still gets propagated.

FYI, I have already started working on this. @mmusgrov @marcosgopen

moulalis · 2023-04-17T07:21:20Z

Hi @mmusgrov, @marcosgopen
Please mark this PR as HOLD.

mmusgrov · 2023-04-18T10:36:54Z

@moulalis I'd have expected you to be able to add the label since I gave you the "Write" Role in github - did you try it first.
Also the expectation is that the PR description should be updated to indicate why the PR is on Hold, do you have the permission to update the PR description?

moulalis · 2023-04-18T10:43:58Z

@moulalis I'd have expected you to be able to add the label since I gave you the "Write" Role in github - did you try it first. Also the expectation is that the PR description should be updated to indicate why the PR is on Hold, do you have the permission to update the PR description?

I apparently added the comment. I realized that I have permission until then @jmfinelli added it.

The HOLD label is needed until https://issues.redhat.com/browse/JBTM-3489 is fixed.

mmusgrov · 2023-04-20T10:09:51Z

@moulalis thanks.

Also, did you notice my comment about the commit history (#434 (review))

…SNAPSHOT.jar

[JBTM-3588] migrate arquillian-protocol-servlet dependency to jakarta [JBTM-3588] jakarta migration, bean auto-discovery set to all see https://jakarta.ee/specifications/cdi/4.0/jakarta-cdi-spec-4.0.html#_jakarta_contexts_and_dependency_injection_4_0

[JBTM-3695] Removed unused/javax dependencies from txbridge [JBTM-3695] Removed unused/javax dependencies from narayana-full [JBTM-3695] Removed unused/javax dependencies from the root pom

…ry mode in lra-client)

…to the [quickstart repo|https://github.com/jbosstm/quickstart]

moulalis · 2023-07-31T09:16:26Z

No changes updated, only rebase is done.

marcosgopen · 2023-07-31T12:40:40Z

rts/at/pom.xml

    <groupId>org.jboss.narayana.quickstart.rts</groupId>
    <artifactId>rts-quickstarts</artifactId>
-    <version>7.0.1.Final-SNAPSHOT</version>
+    <version>6.0.2.Final-SNAPSHOT</version>


Here you need version 7.0.1.Final-SNAPSHOT

…ey each run in their own JVMs,

moulalis · 2023-08-07T12:07:01Z

@mmusgrov @marcosgopen I've updated the PR along with CI tests, could you please review and run the job?

mmusgrov · 2023-08-07T12:13:55Z

Does it work now?

jbosstm-bot · 2023-08-07T12:15:11Z

Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/16/

jbosstm-bot · 2023-08-07T12:41:27Z

Pull passed: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-narayana-quickstart/16/

moulalis · 2023-08-07T13:28:08Z

Does it work now?

Yes

mmusgrov

The contribution looks good, thanks @moulalis for your continued perseverance to see this one through to the end. @marcosgopen do you think that we can merge this one now?

marcosgopen

Thanks @moulalis for your great work on this PR. It looks good to me.

moulalis force-pushed the JBTM-3462 branch from 053bc80 to 7090679 Compare April 10, 2023 14:48

moulalis force-pushed the JBTM-3462 branch 2 times, most recently from 7541237 to f3d9d71 Compare April 11, 2023 18:49

moulalis marked this pull request as ready for review April 11, 2023 18:49

moulalis requested review from jmfinelli, marcosgopen and mmusgrov as code owners April 11, 2023 18:49

moulalis force-pushed the JBTM-3462 branch 2 times, most recently from e944565 to 4475c6d Compare April 12, 2023 05:24

marcosgopen requested changes Apr 12, 2023

View reviewed changes

mmusgrov requested changes Apr 12, 2023

View reviewed changes

moulalis force-pushed the JBTM-3462 branch 2 times, most recently from d51728d to c31d277 Compare April 17, 2023 07:18

jmfinelli added the Hold label Apr 17, 2023

xstefank and others added 15 commits July 31, 2023 13:00

JBTM-3658 Fix the trace logging test properties for WFLY coordinator

0149ac2

JBTM-3588 initial conversion using org.eclipse.transformer.cli-0.6.0-…

a854d75

…SNAPSHOT.jar

JBTM-3588 wip getting most of the tests working

d195bd8

Ensure that the rest-at and sra tests work with jakarta

f22d6b8

Removed unused/javax dependencies from RTS

f4a0e15

[JBTM-3695] Removed unused/javax dependencies from txbridge [JBTM-3695] Removed unused/javax dependencies from narayana-full [JBTM-3695] Removed unused/javax dependencies from the root pom

Updated to 6.0.0.CR1

0d98857

Updated to 6.0.0.Final-SNAPSHOT

315412a

Updated to 6.0.0.Final

10dcbb7

Updated to 6.0.1.Final-SNAPSHOT

100566f

JBTM-3756 update schema version all beans.xml files (and bean discove…

85ab346

…ry mode in lra-client)

Implement BOM in all the Narayana Module

f5b33e2

Updated to 6.0.1.Final

eb47113

Updated to 6.0.2.Final-SNAPSHOT

fe485da

[JBTM:3462] Migrate the SRA demo package (io.narayana.sra.demo) over …

ae84359

…to the [quickstart repo|https://github.com/jbosstm/quickstart]

moulalis force-pushed the JBTM-3462 branch from ed498f9 to 9d0fe20 Compare July 31, 2023 09:05

marcosgopen reviewed Jul 31, 2023

View reviewed changes

moulalis added 2 commits August 7, 2023 17:19

[JBTM-3463] split up each service (hotel, flight and trip) so that th…

ea72317

…ey each run in their own JVMs,

[JBTM-3794] Write Test CI to test annotation example

cc40fd0

moulalis force-pushed the JBTM-3462 branch from 9d0fe20 to cc40fd0 Compare August 7, 2023 12:00

mmusgrov approved these changes Aug 7, 2023

View reviewed changes

marcosgopen approved these changes Aug 14, 2023

View reviewed changes

mmusgrov merged commit f6e81c3 into jbosstm:main Aug 14, 2023

marcosgopen mentioned this pull request Sep 12, 2023

[JBTM-3462] Migrate the SRA demo package jbosstm/narayana#2163

Merged

Migrate the SRA demo package (io.narayana.sra.demo) over to the [quic… #434

Migrate the SRA demo package (io.narayana.sra.demo) over to the [quic… #434

Uh oh!

Conversation

moulalis commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmusgrov commented Apr 11, 2023

Uh oh!

moulalis commented Apr 11, 2023

Uh oh!

mmusgrov commented Apr 11, 2023

Uh oh!

mmusgrov commented Apr 11, 2023

Uh oh!

moulalis commented Apr 11, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcosgopen commented Apr 12, 2023

Uh oh!

mmusgrov commented Apr 12, 2023

Uh oh!

mmusgrov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmusgrov commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmusgrov commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcosgopen commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmusgrov commented Apr 13, 2023

Uh oh!

moulalis commented Apr 13, 2023

Uh oh!

moulalis commented Apr 17, 2023

Uh oh!

mmusgrov commented Apr 18, 2023

Uh oh!

moulalis commented Apr 18, 2023

Uh oh!

mmusgrov commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moulalis commented Jul 31, 2023

Uh oh!

marcosgopen Jul 31, 2023

Choose a reason for hiding this comment

Uh oh!

moulalis commented Aug 7, 2023

Uh oh!

mmusgrov commented Aug 7, 2023

Uh oh!

jbosstm-bot commented Aug 7, 2023

Uh oh!

jbosstm-bot commented Aug 7, 2023

Uh oh!

moulalis commented Aug 7, 2023

Uh oh!

mmusgrov left a comment

Choose a reason for hiding this comment

Uh oh!

marcosgopen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

moulalis commented Apr 10, 2023 •

edited

Loading

mmusgrov commented Apr 12, 2023 •

edited

Loading

mmusgrov commented Apr 12, 2023 •

edited

Loading

marcosgopen commented Apr 12, 2023 •

edited

Loading

mmusgrov commented Apr 20, 2023 •

edited

Loading