#38: Refactor the Manifests class to an immutable #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job #43 is now in scope, role is |
yegor256
reviewed
Jan 30, 2018
| @@ -40,15 +41,67 @@ | |||
| * @since 1.1 | |||
| * @see Manifests | |||
| */ | |||
| public interface MfMap extends Map<String, String> { | |||
| public interface MfMap { | |||
There was a problem hiding this comment.
@proshin-roman Maybe it's not a good idea to change the public interface of classes that are already in production? Also, what do we gain from this?
|
@proshin-roman see my comment. Also, what was the problem you were solving? What was wrong? |
|
@rultor merge |
|
Job |
|
The job #43 is now out of scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made Manifests file immutable. As well I added
asMap()method that returns a copy of an internal map of attributes. MethodkeySet()returns a copy of keys set too.