Move button text when pressing #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jdan/98css/irm0812w5 |
|
Hi! Unfortunately this approach causes the button to shrink slightly
(the left button is 1px shorter). I think we'll need to head back to the drawing board in #44, but I appreciate you taking the time to send this my way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34 .
I went with an invisible
borderinstead of changing the button'spadding, as per @tpenguinltg 's suggestion on #44.Looks like it works fine in the most recent versions of Chrome, Firefox and Safari on Mac.
Here's how it looks (might be hard to see the difference, though):
(I think there's an unrelated bug on Safari which changes the button text
colortowhite, and the dottedoutlineonly shows up on Chrome)Also, this is my very first PR, ever :)