Skip to content

v5.2.10: Fix mise download on Windows when MSYS curl is first on PATH

Latest

Choose a tag to compare

@github-actions github-actions released this 18 Nov 18:31
Immutable release. Only release title and notes can be modified.
90f833d

On Windows, the action can now download mise when an MSYS curl.exe (for example the Rtools one added by r-lib/actions/setup-r) comes first on PATH. Before this fix, the download failed every time while fetching the packslip bundle.

Fixed

  • mise downloads no longer fail on Windows with MSYS curl. r-lib/actions/setup-r puts the Rtools curl.exe first on PATH. When mise-action ran after it, the mise zip downloaded, but every attempt to fetch packslip.sigstore.json failed with Error: Could not download …/packslip.sigstore.json:. The job stopped after five retries.

    The cause was a literal newline in curl's --write-out argument. MSYS curl splits that newline, so the action couldn't read the HTTP status from the response. curl now always writes the response body to a file, and --write-out contains no newline. wget downloads are unchanged. If you ran mise-action before setup-r to work around this, you can now run them in either order. (#744 by @jdx, fixes #743 reported by @eitsupi)

Full Changelog: v5.2.9...v5.2.10