Skip to content

conditionally alter button-label #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 13, 2017
Merged

conditionally alter button-label #274

merged 5 commits into from
Jan 13, 2017

Conversation

ashmaroli
Copy link
Member

conditionally alter the label of the button for 'New posts' or 'New documents' based on the current collection.

@ashmaroli ashmaroli mentioned this pull request Jan 13, 2017
Closed
@mertkahyaoglu
Copy link
Member

mertkahyaoglu commented Jan 13, 2017 •
edited
Loading

  • Added the test for new button's label
  • Lowercased the content type to make it consistent with other buttons (New page, New data file, etc.)

@mertkahyaoglu mertkahyaoglu merged commit 921524d into jekyll:master Jan 13, 2017
@mertkahyaoglu
Copy link
Member

Nice team work here @ashmaroli 🎉

@ashmaroli
Copy link
Member Author

ashmaroli commented Jan 14, 2017 •
edited
Loading

Nice team work

@mertkahyaoglu yeah, I'll try to chip-in more, in the future 😃 😇
Thank you for all the assistance and inputs.

@ashmaroli ashmaroli deleted the new-btn-label branch March 11, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashmaroli @mertkahyaoglu