-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Optimizations #2994
Conversation
430553c
to
fbe98df
Compare
/cc @gjtorikian Does this speed up your site's generation time? |
Jekyll is complicated: |
Yay! Faster builds for everyone! ✨ 🍰 |
People with large sites will likely be the only ones to really notice a huge difference. But yeah we cut down CPU time in our code a bit. Asking the Liquid team about meeting me halfway: Shopify/liquid#457 |
By about ten seconds, which is pretty nice. It takes about a minute to complete the whole shebang. I copied your benchmark script in #2993 and it looks like almost 50% of the time is spent by It looks like another sore spot is https://github.com/gjtorikian/jekyll-last-modified-at. It adds about 10 seconds (!) to the build. Not really sure we can do anything about that, though. |
@gjtorikian, can you send me the stackprof output and dump file? Feel free to email if it's confidential. |
This reverts commit b624150.
Based on #2993.
This actually sped up the build of
jekyllrb.com
quite a bit already. Such simple fixes! Mostly low-hanging fruit.