Performance Optimizations #2994

Merged
merged 10 commits into from Oct 12, 2014

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Oct 12, 2014

Based on #2993.

This actually sped up the build of jekyllrb.com quite a bit already. Such simple fixes! Mostly low-hanging fruit.

@parkr parkr self-assigned this Oct 12, 2014

@parkr parkr added the Enhancement label Oct 12, 2014

@parkr parkr merged commit 00d29e7 into master Oct 12, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the fixes-from-benchmarking branch Oct 12, 2014

parkr added a commit that referenced this pull request Oct 12, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 12, 2014

Member

/cc @gjtorikian Does this speed up your site's generation time?

Member

parkr commented Oct 12, 2014

/cc @gjtorikian Does this speed up your site's generation time?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 12, 2014

Member

Jekyll is complicated:

stackprof-20141012

generated by this graphviz file

Member

parkr commented Oct 12, 2014

Jekyll is complicated:

stackprof-20141012

generated by this graphviz file

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Oct 13, 2014

Member

Yay! Faster builds for everyone! 🍰

Member

alfredxing commented Oct 13, 2014

Yay! Faster builds for everyone! 🍰

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 13, 2014

Member

People with large sites will likely be the only ones to really notice a huge difference. But yeah we cut down CPU time in our code a bit. Asking the Liquid team about meeting me halfway: Shopify/liquid#457

Member

parkr commented Oct 13, 2014

People with large sites will likely be the only ones to really notice a huge difference. But yeah we cut down CPU time in our code a bit. Asking the Liquid team about meeting me halfway: Shopify/liquid#457

@gjtorikian

This comment has been minimized.

Show comment
Hide comment
@gjtorikian

gjtorikian Oct 15, 2014

Member

Does this speed up your site's generation time?

By about ten seconds, which is pretty nice. It takes about a minute to complete the whole shebang.

I copied your benchmark script in #2993 and it looks like almost 50% of the time is spent by Liquid::Block#render_all. It looks like you're on top of that, too. I'm super interested in following that discussion.

It looks like another sore spot is https://github.com/gjtorikian/jekyll-last-modified-at. It adds about 10 seconds (!) to the build. Not really sure we can do anything about that, though.

Member

gjtorikian commented Oct 15, 2014

Does this speed up your site's generation time?

By about ten seconds, which is pretty nice. It takes about a minute to complete the whole shebang.

I copied your benchmark script in #2993 and it looks like almost 50% of the time is spent by Liquid::Block#render_all. It looks like you're on top of that, too. I'm super interested in following that discussion.

It looks like another sore spot is https://github.com/gjtorikian/jekyll-last-modified-at. It adds about 10 seconds (!) to the build. Not really sure we can do anything about that, though.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 15, 2014

Member

@gjtorikian, can you send me the stackprof output and dump file? Feel free to email if it's confidential.

Member

parkr commented Oct 15, 2014

@gjtorikian, can you send me the stackprof output and dump file? Feel free to email if it's confidential.

ericwcy added a commit to ericwcy/jekyll that referenced this pull request Oct 18, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.