Do not swallow all exceptions on render

[pathawks]

Fixes #5104

[pathawks]

/cc: @jekyll/build

[pathawks]

Digging into this a bit deeper, I can trace this all the way back to commit number two, when this was still called autoblog 7dfe32a

Here is what the function looked like:

    def read_layouts
      base = File.join(self.root, "_layouts")
      dir = Dir.new(base)
      dir.each do |f|
        unless %w{. ..}.include?(f)
          name = f.split(".")[0..-2].join(".")
          self.layouts[name] = File.read(File.join(base, f))
        end
      end
    rescue Errno::ENOENT => e
      # ignore missing layout dir
    end

So, it looks like this was not ever meant to swallow some exception in a called function, it was doing all the business right there. I guess we've just carried the cruft along and now here we are, eight years later.

[parkr]

Probably from the File.read call. I'd be interested in just doing a File.exist? call there instead.

[pathawks]

Probably from the File.read call. I'd be interested in just doing a File.exist? call there instead.

Sorry to confuse; the code that I posted there is way old and gone. Was just trying to show why this rescue was originally added. We currently don't have any File.read calls 👍

[parkr]

@pathawks Merge as +bug when CI passes. 😄

[pathawks]

when CI passes

You mean appveyor? master is failing on appveyor

[parkr]

@pathawks Nope! Travis was failing earlier. I kicked it and it passed. 😄

@jekyllbot: merge +bug