Merge pull request #428 from jenkinsci/npe-additional-properties

Fix NPE when line number is not present in model

Author: uhafner

plugin/src/main/java/io/jenkins/plugins/coverage/targets/CoverageResult.java

@@ -828,7 +828,7 @@ public void addAdditionalProperty(final String propertyName, final String value)
     }
 
     public Set<String> getAdditionalProperty(final String propertyName) {
-        return additionalProperties.get(propertyName);
+        return additionalProperties.getOrDefault(propertyName, Collections.emptySet());
     }
 
     /**

plugin/src/test/java/io/jenkins/plugins/coverage/model/CoverageResultTest.java

@@ -29,6 +29,13 @@ class CoverageResultTest extends AbstractCoverageTest {
     private static final CoverageElement SOURCE_FILE = CoverageElement.FILE;
     private static final CoverageElement CLASS_NAME = JavaCoverageReportAdapterDescriptor.CLASS;
 
+    @Test
+    void shouldNeverReturnNullForSets() throws CoverageException {
+        CoverageResult project = readReport("jacoco-codingstyle.xml");
+
+        assertThat(project.getAdditionalProperty("not-found")).isEmpty();
+    }
+
     @Test
     void shouldReadJaCoCoResult() throws CoverageException {
         CoverageResult project = readReport("jacoco-codingstyle.xml");