Skip to content

Conversation

bitwiseman
Copy link
Contributor

@bitwiseman bitwiseman commented Jul 22, 2019

Backport of PR-708

#708 fixes JENKINS-43802. This a backport of the that change to the 3.10 line. It pulls in JENKINS-52964 and requires scm-api v2.6.3.
@jglick @MarkEWaite

@jglick
Copy link
Member

jglick commented Jul 22, 2019

Why is this targeted to master if it is a backport? Should it not be targeted to stable-3.10?

@bitwiseman bitwiseman changed the base branch from master to stable-3.10 July 22, 2019 18:22
Requiring scm-api 2.6.3 instead of scm-api 2.2.7
@bitwiseman bitwiseman marked this pull request as ready for review July 22, 2019 18:56
@bitwiseman
Copy link
Contributor Author

@MarkEWaite @jglick
Thanks!

@MarkEWaite MarkEWaite added the bugfix Fixes a bug - used by Release Drafter label Jul 22, 2019
@MarkEWaite MarkEWaite changed the base branch from stable-3.10 to stable-3.x July 23, 2019 22:33
@bitwiseman
Copy link
Contributor Author

bitwiseman commented Jul 26, 2019

@jglick
Does this look good to you now? Approve?

@MarkEWaite
Could we merge this and get it released? It would be good to get this available.

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Jul 26, 2019

I'll try to run my interactive tests on this pull request this weekend to confirm that it is good to go. Once confirmed that it is good to go, I'll create the release.

I need to create a baseline environment for comparison with git plugin 4.0.0 pre-release anyway, so this is a good excuse to launch a parallel environment with a pre-release of git plugin 3.11.0.

@MarkEWaite MarkEWaite merged commit 281ba5b into jenkinsci:stable-3.x Jul 27, 2019
@MarkEWaite
Copy link
Contributor

Released in git plugin 3.11.0 on July 27, 2019

@bitwiseman bitwiseman deleted the backport-pr-708 branch July 29, 2019 17:39
@olivergondza
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants