add support for allowEmptyResults option in JUnit Plugin #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
| @@ -153,6 +153,7 @@ class PublisherContext extends AbstractExtensibleContext { | |||
| testResults(glob) | |||
| keepLongStdio(junitContext.retainLongStdout) | |||
| testDataPublishers(junitContext.testDataPublishersContext.testDataPublishers) | |||
| allowEmptyResults(junitContext.allowEmptyResults) | |||
There was a problem hiding this comment.
This will break compatibility for everyone using an older version of the JUnit plugin. The new element should only be generated when a minimum version of the plugin is installed, e.g.
if (jobManagement.isMinimumPluginVersionInstalled('junit', '1.10')) {
allowEmptyResults(junitContext.allowEmptyResults)
}
|
Conflict mentioned above is in docs/Home.md - * Removed anything that has been deprecated in 1.36, see Migration
Merged the pull request into my local branch, built, deployed on Jenkins 1.625.3 w/ the junit-1.10 plugin and verified the patch works in a job that generates other jobs via DSL and includes the new allowEmptyResults option. |
kamilszymanski
force-pushed
the
junit-publish-on-empty-reults
branch
from
a9095a0
to
34d09b7
Compare
|
rebased on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.