-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mrca, branch_length and kc_distance functions with tests #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few minor comments.
We don't need to get too rigid about keeping the tskit dependencies minimised, but things like num_nodes
are well defined in terms of the parent_array
.
Looks like you need to rebase - as a rule of thumb, you never merge especially when git suggests you do! |
76c3291
to
d01130f
Compare
Looks like you're not having much fun with the rebasing @Billyzhang1229 - how about Ben or I take you through it? |
True, I'll probably try a few more times today, I need more practice on it and reach out to you or Ben if I can't solve it by tomorrow.🙃 |
Add check_node_bounds() functions Remove duplicate test in test_distance.py
As another git tip, it is best to work on a topic branch rather than your |
I see, it is my first time to fork an upstream repository and work on it, normally I would just branch in my repository and merge it to |
There's loads more tips at https://tskit.dev/tskit/docs/stable/development.html#git-workflow if you haven't already seen it. |
This has conflicts now @Billyzhang1229 - we can go through how to do this tomorrow. |
Closed in favour of #15 which has a named branch. |
✅ mrca
✅ branch_length
✅ kc_distance