Fix old-style function definitions and enable warning.

Tilmann Scheller · Tilmann Scheller · commit e99e41c5350b · 2017-03-09T12:53:03.000+01:00
Function definitions with no parameters should always use the void keyword to allow the compiler to catch invalid calls of those functions at compile time. Enable -Wold-style-definition to catch this early in the future. Fixes #1649. JerryScript-DCO-1.0-Signed-off-by: Tilmann Scheller t.scheller@samsung.com
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -179,7 +179,7 @@ jerry_add_compile_flags(-fno-stack-protector)
 endif()
 
 if (USING_GCC OR USING_CLANG)
-  jerry_add_compile_warnings(all extra format-nonliteral init-self conversion sign-conversion format-security missing-declarations shadow strict-prototypes undef)
+  jerry_add_compile_warnings(all extra format-nonliteral init-self conversion sign-conversion format-security missing-declarations shadow strict-prototypes undef old-style-definition)
   jerry_add_compile_flags(-Wno-stack-protector -Wno-attributes)
 endif()
 
diff --git a/docs/05.PORT-API.md b/docs/05.PORT-API.md
@@ -196,7 +196,7 @@ bool jerry_port_get_time_zone (jerry_time_zone_t *tz_p)
 /**
  * Default implementation of jerry_port_get_current_time.
  */
-double jerry_port_get_current_time ()
+double jerry_port_get_current_time (void)
 {
   struct timeval tv;
 
diff --git a/jerry-core/debugger/jerry-debugger-ws.c b/jerry-core/debugger/jerry-debugger-ws.c
@@ -311,7 +311,7 @@ jerry_process_handshake (int client_socket, /**< client socket */
  *         false - otherwise
  */
 bool
-jerry_debugger_accept_connection ()
+jerry_debugger_accept_connection (void)
 {
   int server_socket;
   struct sockaddr_in addr;
diff --git a/jerry-core/jmem/jmem-allocator.c b/jerry-core/jmem/jmem-allocator.c
@@ -37,7 +37,7 @@ jmem_init (void)
  * Finalize memory allocators.
  */
 void
-jmem_finalize ()
+jmem_finalize (void)
 {
   jmem_pools_finalize ();
 
diff --git a/jerry-core/jmem/jmem-poolman.c b/jerry-core/jmem/jmem-poolman.c
@@ -191,7 +191,7 @@ jmem_pools_free (void *chunk_p, /**< pointer to the chunk */
  *  Collect empty pool chunks
  */
 void
-jmem_pools_collect_empty ()
+jmem_pools_collect_empty (void)
 {
   jmem_pools_chunk_t *chunk_p = JERRY_CONTEXT (jmem_free_8_byte_chunk_p);
   JERRY_CONTEXT (jmem_free_8_byte_chunk_p) = NULL;
diff --git a/jerry-core/parser/regexp/re-compiler.c b/jerry-core/parser/regexp/re-compiler.c
@@ -488,7 +488,7 @@ re_find_bytecode_in_cache (ecma_string_t *pattern_str_p, /**< pattern string */
  * Run gerbage collection in RegExp cache
  */
 void
-re_cache_gc_run ()
+re_cache_gc_run (void)
 {
   for (uint32_t i = 0u; i < RE_CACHE_SIZE; i++)
   {
diff --git a/targets/curie_bsp/source/curie-bsp-port.c b/targets/curie_bsp/source/curie-bsp-port.c
@@ -84,7 +84,7 @@ bool jerry_port_get_time_zone (jerry_time_zone_t *tz_p)
 /**
  * Curie BSP implementation of jerry_port_get_current_time.
  */
-double jerry_port_get_current_time ()
+double jerry_port_get_current_time (void)
 {
   uint32_t uptime_ms = get_uptime_ms ();
   uint32_t epoch_time = uptime_to_epoch (uptime_ms);
diff --git a/targets/default/jerry-port-default-date.c b/targets/default/jerry-port-default-date.c
@@ -50,7 +50,7 @@ bool jerry_port_get_time_zone (jerry_time_zone_t *tz_p)
 /**
  * Default implementation of jerry_port_get_current_time.
  */
-double jerry_port_get_current_time ()
+double jerry_port_get_current_time (void)
 {
 #ifdef __GNUC__
   struct timeval tv;
diff --git a/targets/default/jerry-port-default-fatal.c b/targets/default/jerry-port-default-fatal.c
@@ -36,7 +36,7 @@ void jerry_port_default_set_abort_on_fail (bool flag) /**< new value of 'abort o
  * @return true - if 'abort on fail' flag is set,
  *         false - otherwise.
  */
-bool jerry_port_default_is_abort_on_fail ()
+bool jerry_port_default_is_abort_on_fail (void)
 {
   return abort_on_fail;
 } /* jerry_port_default_is_abort_on_fail */
diff --git a/targets/mbed/source/port/jerry_port.c b/targets/mbed/source/port/jerry_port.c
@@ -79,7 +79,7 @@ jerry_port_get_time_zone (jerry_time_zone_t *tz_p) /**< timezone pointer */
  * @return current timer's counter value in microseconds 
  */
 double
-jerry_port_get_current_time ()
+jerry_port_get_current_time (void)
 {
   return (double) us_ticker_read ();
 } /* jerry_port_get_current_time */
diff --git a/targets/mbedos5/source/jerry_port_mbed.c b/targets/mbedos5/source/jerry_port_mbed.c
@@ -93,7 +93,7 @@ jerry_port_get_time_zone (jerry_time_zone_t *tz_p) /**< timezone pointer */
  * @return current timer's counter value in microseconds
  */
 double
-jerry_port_get_current_time ()
+jerry_port_get_current_time (void)
 {
   return (double) us_ticker_read ();
 } /* jerry_port_get_current_time */
diff --git a/targets/nuttx-stm32f4/jerry_main.c b/targets/nuttx-stm32f4/jerry_main.c
@@ -304,7 +304,7 @@ jerry_port_get_time_zone (jerry_time_zone_t *tz_p)
  * @return 0
  */
 double
-jerry_port_get_current_time ()
+jerry_port_get_current_time (void)
 {
   return 0;
 } /* jerry_port_get_current_time */
diff --git a/targets/zephyr/src/jerry-port.c b/targets/zephyr/src/jerry-port.c
@@ -65,7 +65,7 @@ void jerry_port_fatal (jerry_fatal_code_t code)
  * @return current timer's counter value in milliseconds
  */
 double
-jerry_port_get_current_time ()
+jerry_port_get_current_time (void)
 {
   int64_t ms = k_uptime_get();
   return (double) ms;

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ bool jerry_port_get_time_zone (jerry_time_zone_t *tz_p)`
`196`	`196`	`/**`
`197`	`197`	`* Default implementation of jerry_port_get_current_time.`
`198`	`198`	`*/`
`199`		`-double jerry_port_get_current_time ()`
	`199`	`+double jerry_port_get_current_time (void)`
`200`	`200`	`{`
`201`	`201`	`struct timeval tv;`
`202`	`202`
Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,7 @@ jerry_process_handshake (int client_socket, /*< client socket /`
`311`	`311`	`* false - otherwise`
`312`	`312`	`*/`
`313`	`313`	`bool`
`314`		`-jerry_debugger_accept_connection ()`
	`314`	`+jerry_debugger_accept_connection (void)`
`315`	`315`	`{`
`316`	`316`	`int server_socket;`
`317`	`317`	`struct sockaddr_in addr;`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ jmem_init (void)`
`37`	`37`	`* Finalize memory allocators.`
`38`	`38`	`*/`
`39`	`39`	`void`
`40`		`-jmem_finalize ()`
	`40`	`+jmem_finalize (void)`
`41`	`41`	`{`
`42`	`42`	`jmem_pools_finalize ();`
`43`	`43`
Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ jmem_pools_free (void chunk_p, /< pointer to the chunk /`
`191`	`191`	`* Collect empty pool chunks`
`192`	`192`	`*/`
`193`	`193`	`void`
`194`		`-jmem_pools_collect_empty ()`
	`194`	`+jmem_pools_collect_empty (void)`
`195`	`195`	`{`
`196`	`196`	`jmem_pools_chunk_t *chunk_p = JERRY_CONTEXT (jmem_free_8_byte_chunk_p);`
`197`	`197`	`JERRY_CONTEXT (jmem_free_8_byte_chunk_p) = NULL;`
Original file line number	Diff line number	Diff line change
`@@ -488,7 +488,7 @@ re_find_bytecode_in_cache (ecma_string_t pattern_str_p, /< pattern string /`
`488`	`488`	`* Run gerbage collection in RegExp cache`
`489`	`489`	`*/`
`490`	`490`	`void`
`491`		`-re_cache_gc_run ()`
	`491`	`+re_cache_gc_run (void)`
`492`	`492`	`{`
`493`	`493`	`for (uint32_t i = 0u; i < RE_CACHE_SIZE; i++)`
`494`	`494`	`{`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ bool jerry_port_get_time_zone (jerry_time_zone_t *tz_p)`
`84`	`84`	`/**`
`85`	`85`	`* Curie BSP implementation of jerry_port_get_current_time.`
`86`	`86`	`*/`
`87`		`-double jerry_port_get_current_time ()`
	`87`	`+double jerry_port_get_current_time (void)`
`88`	`88`	`{`
`89`	`89`	`uint32_t uptime_ms = get_uptime_ms ();`
`90`	`90`	`uint32_t epoch_time = uptime_to_epoch (uptime_ms);`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ bool jerry_port_get_time_zone (jerry_time_zone_t *tz_p)`
`50`	`50`	`/**`
`51`	`51`	`* Default implementation of jerry_port_get_current_time.`
`52`	`52`	`*/`
`53`		`-double jerry_port_get_current_time ()`
	`53`	`+double jerry_port_get_current_time (void)`
`54`	`54`	`{`
`55`	`55`	`#ifdef __GNUC__`
`56`	`56`	`struct timeval tv;`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ void jerry_port_default_set_abort_on_fail (bool flag) /**< new value of 'abort o`
`36`	`36`	`* @return true - if 'abort on fail' flag is set,`
`37`	`37`	`* false - otherwise.`
`38`	`38`	`*/`
`39`		`-bool jerry_port_default_is_abort_on_fail ()`
	`39`	`+bool jerry_port_default_is_abort_on_fail (void)`
`40`	`40`	`{`
`41`	`41`	`return abort_on_fail;`
`42`	`42`	`} /* jerry_port_default_is_abort_on_fail */`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ jerry_port_get_time_zone (jerry_time_zone_t tz_p) /< timezone pointer /`
`79`	`79`	`* @return current timer's counter value in microseconds`
`80`	`80`	`*/`
`81`	`81`	`double`
`82`		`-jerry_port_get_current_time ()`
	`82`	`+jerry_port_get_current_time (void)`
`83`	`83`	`{`
`84`	`84`	`return (double) us_ticker_read ();`
`85`	`85`	`} /* jerry_port_get_current_time */`