Fix tests with same name corrupting the decorator dots. #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests with the same name (e.g. in different describe blocks) currently get the decorator of the last test result.
This is bad behaviour, as its common practice when testing an API under different conditions, to have the scenario be in the
describe
block and the API method under test in thetest
block. I.e. its a valid scenario to have multipletest
blocks with the same key.This adjusts that behaviour, by using the line numbers of the test under KnownFail scenarios to assign the decorators correctly, or otherwise just using the first Success or Unknown case (as they have the same parsed test result anyway -- line numbers being only available in KnownFail scenario).