Skip to content

Conversation

mikeland73
Copy link
Contributor

Summary

Fixes #216

Fixes issue where python can't find modules installed as nix packages.

How was it tested?

testdata/python/pipenv

devbox shell
python -m pipenv

@mikeland73 mikeland73 requested review from loreto and savil October 6, 2022 18:34
@mikeland73 mikeland73 merged commit 8f7f0c0 into main Oct 6, 2022
@mikeland73 mikeland73 deleted the landau/fix-python-sys-path branch October 6, 2022 18:41
@savil
Copy link
Collaborator

savil commented Oct 6, 2022

hmm the test failure looks legit...

--- FAIL: TestDevbox (0.16s)
    --- FAIL: TestDevbox/testdata/python/pipenv (0.00s)
        devbox_test.go:58:
            	Error Trace:	/Users/savil/code/jetpack/devbox/devbox_test.go:58
            	Error:      	Received unexpected error:
            	            	Devbox could not find a buildable plan for this project. If your project/language is currently supported, please create an issue at https://github.com/jetpack-io/devbox/issues - if it's not supported you can request it!
            	            	go.jetpack.io/devbox/boxcli/usererr.New
            	            		/Users/savil/code/jetpack/devbox/boxcli/usererr/usererr.go:15
            	            	go.jetpack.io/devbox/planner.GetBuildPlan
            	            		/Users/savil/code/jetpack/devbox/planner/planner.go:112
            	            	go.jetpack.io/devbox.(*Devbox).BuildPlan
            	            		/Users/savil/code/jetpack/devbox/devbox.go:151
            	            	go.jetpack.io/devbox.(*Devbox).generateBuildFiles
            	            		/Users/savil/code/jetpack/devbox/devbox.go:246
            	            	go.jetpack.io/devbox.(*Devbox).Generate
            	            		/Users/savil/code/jetpack/devbox/devbox.go:164
            	            	go.jetpack.io/devbox.testExample.func1
            	            		/Users/savil/code/jetpack/devbox/devbox_test.go:56
            	            	testing.tRunner
            	            		/usr/local/go/src/testing/testing.go:1446
            	            	runtime.goexit
            	            		/usr/local/go/src/runtime/asm_amd64.s:1594
            	            	go.jetpack.io/devbox.(*Devbox).generateBuildFiles
            	            		/Users/savil/code/jetpack/devbox/devbox.go:248
            	            	go.jetpack.io/devbox.(*Devbox).Generate
            	            		/Users/savil/code/jetpack/devbox/devbox.go:164
            	            	go.jetpack.io/devbox.testExample.func1
            	            		/Users/savil/code/jetpack/devbox/devbox_test.go:56
            	            	testing.tRunner
            	            		/usr/local/go/src/testing/testing.go:1446
            	            		....

@savil
Copy link
Collaborator

savil commented Oct 6, 2022

sent #219 to fix test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'pkg_resources' error after upgrading to Devbox v0.0.9
2 participants