Skip to content

Conversation

savil
Copy link
Collaborator

@savil savil commented Oct 6, 2022

Summary

Fixes this test by making the python pip planner run for it.

did:

touch setup.py
touch requirements.txt

Needed this because devbox_test requires buildable plans.

NOTE: I had to manually edit the generated plan.json to get rid of the absolute paths.
Lets discuss if the planner needs to use these absolute paths, or if relative paths suffice.

How was it tested?

go test ./...

@savil savil requested a review from mikeland73 October 6, 2022 19:12
Copy link
Collaborator Author

savil commented Oct 6, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@savil savil merged commit 22411a6 into main Oct 6, 2022
@savil savil deleted the savil/fix-pipenv-test branch October 6, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants