nix: fix removing user Nix profiles from PATH #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When launching a devbox shell, we filter out any Nix user profiles from
the PATH (i.e., ~/.nix-profile). This fixes a couple of bugs with how we
determine if a PATH directory matches a Nix profile:
1. The `strings.HasPrefix("/Users", profileDir)` call is backwards.
2. Checking for `/Users` is macOS-specific and won't work on Linux.
Instead, check if the directory starts with `/nix` to determine if
it's the default system profile.
|
This is just waiting on the test fix in #219. |
…tis/profile-dirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When launching a devbox shell, we filter out any Nix user profiles from the PATH (i.e., ~/.nix-profile). This fixes a couple of bugs with how we determine if a PATH directory matches a Nix profile:
strings.HasPrefix("/Users", profileDir)call is backwards./Usersis macOS-specific and won't work on Linux. Instead, check if the directory starts with/nixto determine if it's the default system profile.How was it tested?
Added a test.