Enable unified env by default #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Feb 17, 2023
|
tests need updating |
Yeah, working on it on a separate PR |
|
Done in #660 |
ipince
force-pushed
the
rodrigo/enable-unified-env
branch
from
fc56f0f to
ce44e68
Compare
Merged
ipince
added a commit
that referenced
this pull request
Feb 23, 2023
## Summary Adds support for `fish` shell. When running `devbox shell`: We write the post-initialization steps into a "shellrc" file (see `shellrc_fish.tmpl`). I attempted to reuse the existing `shellrc.tmpl`, but the differences in syntax between fish and other shells were large enough that I had to separate them. Next, we invoke `fish -C <shellrc>`. This will make `fish` use the user's existing config first, and _then_ run whatever is in `<shellrc>`, which is similar to what we do for non-fish shells. When running `devbox run`: - If unified env is ON, then we invoke `sh -c <script>` just like we do for every other shell. - If unified env is OFF, then we'll invoke `fish -C <shellrc> -c <script>`. However, note that #650 already enables unified env by default, so this branch is mainly here just in case something goes wrong with unified env and we need to revert. Caveats: - We don't check any of the syntax in devbox.json's init hook or scripts. If an init hook uses fish-specific syntax, then it will work for users using `fish`, but it won't for users using a different shell. Similarly for scripts. Conversely, if an init hook uses POSIX syntax that fish doesn't support (e.g. `FOO=bar`), then the init hook will fail for fish users. - Any plugins that use init hooks should write them in such a way that they work for both fish and non-fish. So far, it seems only `pip` and `ruby` use init hooks, and they're written in a compatible way (AFAIK). ## How was it tested? I tested that both `devbox shell` and `devbox run` worked with and without unified env. I verified that `PATH` was being set, user's config is being run (for shell only), init hooks are being run, history file is set (shell only), prompt is set (shell only), and scripts are written and run. To test with fish, it's as easy as invoking devbox as such: ``` SHELL=fish devbox shell ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I guess it actually was ready right on time on 2/16 :). (but not for a 2/16 release)
How was it tested?
testscript tests and using it while developing