Skip to content

Conversation

ipince
Copy link
Contributor

@ipince ipince commented Feb 21, 2023

Summary

TSIA

How was it tested?

go test

@ipince ipince requested a review from savil February 21, 2023 17:09

autoload -Uz promptinit
promptinit
#prompt adam1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

setopt histignorealldups sharehistory

# Use emacs keybindings even if our EDITOR is set to vi
bindkey -e
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means war

var update = flag.Bool("update", false, "update the golden files with the test results")

func TestWriteDevboxShellrc(t *testing.T) {
os.Setenv("DEVBOX_FEATURE_UNIFIED_ENV", "0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want t.Setenv https://pkg.go.dev/testing#T.Setenv

}

func TestWriteDevboxShellrcWithUnifiedEnv(t *testing.T) {
os.Setenv("DEVBOX_FEATURE_UNIFIED_ENV", "1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

@@ -0,0 +1 @@
PATH=/a/test/path
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this value used?

@ipince ipince merged commit 7fb3374 into main Feb 21, 2023
@ipince ipince deleted the rodrigo/shellrc-tests branch February 21, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants