Fix GlobusGSSContextTest #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GlobusGSSContextTest relies on having a credential, which then relies on X509Credential class not having a cached copy of such a credential. However, it does not ensure there is no such cached credential. Since multiple tests (and test-suites) are run within the same JVM instance, the effect is that, if another test-suite caches a (deliberately) invalid, self-signed certificate then this cached copy is returned instead of the expected certificate. This patch fixes this problem by ensuring the cache is cleared. It introduces a (negliable) overhead as the cache is flushed between tests; however, the additional robustness justifies this cost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GlobusGSSContextTest relies on having a credential, which then relies
on X509Credential class not having a cached copy of such a credential.
However, it does not ensure there is no such cached credential.
Since multiple tests (and test-suites) are run within the same JVM
instance, the effect is that, if another test-suite caches a
(deliberately) invalid, self-signed certificate then this cached
copy is returned instead of the expected certificate.
This patch fixes this problem by ensuring the cache is cleared. It
introduces a (negliable) overhead as the cache is flushed between
tests; however, the additional robustness justifies this cost.
Please commit to v2.0 and cherry-pick to master