Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take out survey #152

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Take out survey #152

merged 3 commits into from
Jun 5, 2023

Conversation

Jackmin801
Copy link
Contributor

@Jackmin801 Jackmin801 commented Jun 5, 2023

Goal

The user experience survey is no longer needed. This PR removes the survey from jcloud.

@jina-ai/team-wolf

Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #152 (dda38f0) into main (bd5057e) will increase coverage by 1.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   60.53%   61.83%   +1.30%     
==========================================
  Files          20       19       -1     
  Lines        1338     1305      -33     
==========================================
- Hits          810      807       -3     
+ Misses        528      498      -30     
Flag Coverage Δ
jcloud 61.83% <ø> (+1.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jcloud/api.py 39.90% <ø> (+0.09%) ⬆️
jcloud/flow.py 83.16% <ø> (+0.49%) ⬆️
jcloud/parsers/__init__.py 100.00% <ø> (ø)

@Jackmin801
Copy link
Contributor Author

Eh let the branch workflow integration test run first. If it works without the flag then we should be good for merge.

The main integration test still has the flag so passing on that just means the code is not broken. It wont tell us whether or not the survey was correctly removed.

@Jackmin801
Copy link
Contributor Author

Yep shud be okz

@Jackmin801 Jackmin801 merged commit ea4b75d into main Jun 5, 2023
@Jackmin801 Jackmin801 deleted the take-out-survey branch June 5, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants