Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take out survey #152

Merged
merged 3 commits into from
Jun 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ jobs:
id: test
run: |
export JCLOUD_LOGLEVEL=DEBUG
export JCLOUD_NO_SURVEY=1
pytest --suppress-no-test-exit-code --cov=jcloud --cov-report=xml \
-v -s --log-cli-level=DEBUG -m "not gpu" ${{ matrix.test-path }}
echo "::set-output name=codecov_flag::jcloud"
Expand Down
7 changes: 0 additions & 7 deletions jcloud/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -330,13 +330,6 @@ def new(args):
)


def survey(args):
# ask feedback
from .survey import Survey

Survey().ask(-1)


@asyncify
async def update(args):
from rich import print
Expand Down
5 changes: 0 additions & 5 deletions jcloud/flow.py
Original file line number Diff line number Diff line change
Expand Up @@ -514,11 +514,6 @@ async def __aenter__(self):
pbar.console.print(self)
pbar.update(pb_task, description='Finishing', advance=1)

if 'JCLOUD_NO_SURVEY' not in os.environ:
# ask feedback
from .survey import Survey

Survey().count().ask(threshold=3)
return self

async def __aexit__(self, *args, **kwargs):
Expand Down
6 changes: 0 additions & 6 deletions jcloud/parsers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,4 @@ def get_main_parser(parser=None):
)
)

sp.add_parser(
'survey',
help='Tell us your experience and help us improve.',
formatter_class=_chf,
)

return parser
51 changes: 0 additions & 51 deletions jcloud/survey.py

This file was deleted.