Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using {fmt} to replace printf, iostream, and misc string operations #83

Merged
merged 22 commits into from
Nov 12, 2024
Merged

Using {fmt} to replace printf, iostream, and misc string operations #83

merged 22 commits into from
Nov 12, 2024
+388 −405

Conversation

jj1bdx
Copy link
Owner

@jj1bdx jj1bdx commented Nov 12, 2024

  • Mandate {fmt} 11.0.2 as a required library
    • Preparing for future C++23 std::print()
  • Refactor to use fmt functions for printing messages
    • Remove (f)printf, iostream, crude string operations
  • Refactor CMakeLists.txt

jj1bdx added 22 commits November 11, 2024 01:25
@jj1bdx
CMakeLists.txt: add basic fmt library support
9d5fdb1
@jj1bdx
Convert fprintf to fmt with clang-tidy
32bee30 
* Still preliminary: manual fixes required
* usage() is reimplemented with std::string usage string

```
clang-tidy --fix --fix-errors --config-file=./modernize-print.yaml -checks="modernize-use-std-print" main.cpp
```
@jj1bdx
UNTESTED: replace fprintf() to fmt for ifdef code blocks
c465b18
@jj1bdx
usage(): revert to implicitly-concatenated strings
bc23399
@jj1bdx
CMakeList: use fetched {fmt} 11.0.2 explicitly
e4f5c7d 
* Fetch fmt 11.0.2 from GitHub
    * Ubuntu/Debian libfmt-dev is old and do not support <fmt/base.h>
* fmt 11.0.2 is statically linked to sfmbase
* airspy-fmradion is linked to sfmbase
* explicit linkage of airspy-fmradion to fmt is not required
@jj1bdx
Add libfmt.md
aa610bb
@jj1bdx
CMakeLists: revert and use installed libfmt
db52b30
@jj1bdx
Change #include <fmt/base.h> to <fmt/format.h>
5fb9566
@jj1bdx
Update docs for libfmt requirement
8da9621
@jj1bdx
CMakeLists.txt: add notice of compilation errors of fmt library
7fe4db2
@jj1bdx
Remove modernize-print.yaml
316728b
@jj1bdx
AirspyHFSource: use fmt instead of streams
2ed3cd3
@jj1bdx
AirspySource: use fmt instead of streams
a2f457c
@jj1bdx
AirspySource: clang-format
4db52dc
@jj1bdx
main.cpp: remove redundant std::to_string()
9bcd4dc
@jj1bdx
Use fmt std::vector output for error messages
2c90932
@jj1bdx
AudioOutput.cpp: remove std::to_string()
fac3be4
@jj1bdx
RtlSdrSource: use fmt std::vector output for error messages
1b0d0f7
@jj1bdx
Use fmt::join() for parameter listing
2650da5
@jj1bdx
FileSource: use fmt to refactor
6e21bf0
@jj1bdx
AudioOutput: use fmt to refactor m_error processing
b6bc856
@jj1bdx
CMakeLists: add REQUIRED flags
cda9de8
@jj1bdx jj1bdx changed the base branch from main to dev November 12, 2024 03:42
@jj1bdx
Copy link
Owner Author

jj1bdx commented Nov 12, 2024

LGTM!

@jj1bdx jj1bdx merged commit 313d8c7 into dev Nov 12, 2024
@jj1bdx jj1bdx deleted the dev-libfmt branch November 12, 2024 03:43
@jj1bdx jj1bdx mentioned this pull request Nov 12, 2024
Open
@jj1bdx jj1bdx mentioned this pull request Dec 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jj1bdx