forked from rails/rails
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug test connection pool starts reaper in fork #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_with-in-form_helper docs: Update FormHelper comments to use `form_with` instead of `form_for` [ci skip]
When `to_time_preserves_timezone` was set to `false`, `to_time` would return a `Time` object with local timezone. This behavior has been removed.
… `ActiveSupport::LogSubscriber::BOLD`
… in `ActiveSupport::LogSubscriber#color`
This change was never released on 7.1, so we can't remove it on 7.2.
…ng a deprecator - `deprecate` - `deprecate_constant` - `ActiveSupport::Deprecation::DeprecatedObjectProxy.new` - `ActiveSupport::Deprecation::DeprecatedInstanceVariableProxy.new` - `ActiveSupport::Deprecation::DeprecatedConstantProxy.new` - `assert_deprecated` - `assert_not_deprecated` - `collect_deprecations`
…`ActiveSupport::Notifications::Event#parent_of?`
…tion-in-ci Avoid seed data execution in CI by replacing `db:setup` with `db:test:prepare`
Remove all deprecated code
…e_table Pass validate(_check)_constraint through change_table
This will greatly increase the visibility of Rails console commands and helpers, and stop rely on IRB's internal components. Extension API reference: https://github.com/ruby/irb/blob/master/EXTEND_IRB.md And because we need to create new classes to use the new APIs, I also moved all the IRB-specific code to a new file, `irb_console.rb`. Use IRB.conf[:BACKTRACE_FILTER] for backtrace filtering in console This change uses the new `IRB.conf[:BACKTRACE_FILTER]` to inject the backtrace filtering logic into IRB. This avoids the need to patch IRB's internal WorkSpace class. Update changelog
…gelog-for-51878 Add test and fix changelog for `schema_cache_ignored_table?`
…record Document the transaction.active_record event
…activesupport-json-encode" This reverts commit 7b9e9ee, reversing changes made to 590a675. Reason: rails#50489 (comment)
Temporarily fix multi-paragraph definition lists [ci skip]
This allow us to actually get a working gem from github.
…atch-between-revert-code-example-and-subsequent-steps Adjusted an example to align with the documentation section on reversing a previous migration.
…ame demodularized name
…me-as-demodularized-model-name [Fix rails#51720] Infer association klass as top level if model has same demodularized name
Also update eslint-plugin-import from 2.27.5 to 2.29.0. Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
…fter_commit_deduplication" This reverts commit 2abee30, reversing changes made to e34a0ee. A warning on each method is excessive and the warning should already be covered under the guide: https://edgeguides.rubyonrails.org/active_record_callbacks.html#transaction-callbacks
Revert "Merge pull request rails#51184 from ConfusedVorlon/document_after_commit_deduplication"
Was done in 3e08223 to work around a RuboCop bug. The newest version has this fixed.
postgresql was renamed to postgresql@14 in the Homebrew upstream and now postgresql@16 is the latest stable, so we can use postgresql@16 in the development environment. cf. Homebrew/homebrew-core@8060df9 Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Upstream sqlite updated the error messages to be more descriptive starting in v3.46.0. Where the error message might look like this in earlier versions: no such column: non_existent in 3.46.0 it looks like: no such column: "non_existent" - should this be a string literal in single-quotes? The tests have been updated to accept either style of message. The sqlite3-ruby gem will release a version with this vendored version shortly, see sparklemotion/sqlite3-ruby#536
chore: update Brewfile per renaming postgresql Formula
…to-8.40.0 chore(deps-dev): update eslint from 4.19.1 to 8.40.0
This dependency was originally introduced in PR 33079 in Rails 6.0 (2018). Follows up PR 43172, which replaced webpacker 6 with jsbundling-rails in Rails 7.0 (2021). Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
…lite3-test-messages update sqlite3 adapter tests to accept error messages from v3.46.0
chore: remove webpack from yarn dependencies in Rails dev
Revert RuboCop workaround
Add rubocop and GitHub Actions to plugin generator
* Lookup route from requirements * Add docs * Strings instead of symbols S * Update actionpack/lib/action_dispatch/routing/route_set.rb Co-authored-by: Rafael Mendonça França <rafael@franca.dev> * Update actionpack/lib/action_dispatch/routing/route_set.rb Co-authored-by: Rafael Mendonça França <rafael@franca.dev> * Update actionpack/lib/action_dispatch/routing/route_set.rb Co-authored-by: Rafael Mendonça França <rafael@franca.dev> * Update actionpack/lib/action_dispatch/routing/route_set.rb Co-authored-by: Rafael Mendonça França <rafael@franca.dev> --------- Co-authored-by: Andy Waite <andyw8@users.noreply.github.com> Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:disabled
withnil
--asset-pipeline
when runningapp:update
#in_order_of
[ci-skip]in_order_of
documentationdestroy_async
job for owners with composite primary keysapply_rubocop_autocorrect_after_generate!
with--pretend
mathn
related testsave_and_open_page
helper to IntegrationTest#with_routing
helper:n_plus_one_only
does not eagerly load child associations.save_and_open_page
tests#lease_connection
over#connection
on AR model#inspect
without connectionMime::Type.parse
for HTTP Accept with parametersActiveSupport::ProxyObject
Module#include
rather thanprepend
since we don't needprepend
semantics here andinclude
leads to faster method lookups.rename_table
includes+references
for models with composite primary keysselenium-webdriver
version 4.20.0selenium-webdriver
ActiveRecord::Relation#with
ActiveSupport::ProxyObject
deprecation logs (Fix minor typo inActiveSupport::ProxyObject
deprecation logs rails/rails#51688)require: "debug/prelude"
afterdebug
's Gemfile entryFileUpdateChecker
db:setup
withdb:test:prepare
form_with
instead ofform_for
config.active_storage.replace_on_assign_to_many
config.active_storage.silence_invalid_content_types_warning
to_time
:pool_size
and:pool_timeout
options for the cache storageconfig.active_support.cache_format_version = 6.1
ActiveSupport::LogSubscriber::CLEAR
andActiveSupport::LogSubscriber::BOLD
ActiveSupport::LogSubscriber#color
config.active_support.disable_to_s_conversion
config.active_support.remove_deprecated_time_with_zone_name
config.active_support.use_rfc4122_namespaced_uuids
Dalli::Client
instances toMemCacheStore
#to_default_s
fromArray
,Date
,DateTime
andTime
SafeBuffer#clone_empty
ActiveSupport::Deprecation
delegation to instanceActiveSupport::Notifications::Event#children
andActiveSupport::Notifications::Event#parent_of?
assert_equal
withnil
Rails.application.secrets
Rails.config.enable_dependency_loading
find_cmd_and_exec
console helperRails::Generators::Testing::Behaviour
stale_state
to Stringlease_connection
calls_reflections
duration
inActiveSupport::XmlMini
ActiveRecord::Result#hash_rows
query_constraints:
behavior.with_connection
to not set current scopeActiveRecord::Relation#touch_all
with custom attribute aliased as attribute for update:if_not_exists
and:force
options tocreate_schema
touch_all
in batchesActiveRecord::SignedId
to not rely on relation delegationActiveRecord::TokenFor
to not rely on relation delegationActiveRecord::Base.delete
inRelation
ActiveRecord::Base.destroy
inRelation
ActiveRecord::Base.insert
inRelation
foreign_key
option for destroy_async test modelsBatchEnumerator#destroy_all
to return the total number of affected rowsprefix
for nillease_connection
call incached_find_by
queue_adapter_for_test
i18n
gem repository [ci-skip]active_record.postgresql_adapter_decode_dates
to toggle automatic decoding of dates column with the PostgresqlAdapter.Layout/IndentationWidth
cop offensesschema_cache_ignored_tables?
schema_cache_ignored_table?
revert
Code Example and Subsequent Steps rails/rails#50189 docs section reverting previous migrations mismatch code exampleMotivation / Background
This Pull Request has been created because [REPLACE ME]
Detail
This Pull Request changes [REPLACE ME]
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]